mojo/public/js/bindings/validation_unittests.js - Issue 628763002: Mojo JS bindings: simplify mojo.connectToService() usage - Part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/js/bindings/validation_unittests.js

Issue 628763002: Mojo JS bindings: simplify mojo.connectToService() usage - Part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed template indentation Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/js/bindings/struct_unittests.js ('k') | mojo/public/tools/bindings/generators/js_templates/enum_definition.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/js/bindings/validation_unittests.js

diff --git a/mojo/public/js/bindings/validation_unittests.js b/mojo/public/js/bindings/validation_unittests.js

index 73fd9c7142450e7423c881e76509d57cbf4a817d..59aeb59e7f68d6defc672bc5d3b8f1eefd21180d 100644

--- a/mojo/public/js/bindings/validation_unittests.js

+++ b/mojo/public/js/bindings/validation_unittests.js

@@ -246,12 +246,12 @@ define([

function testConformanceMessageValidation() {

testMessageValidation("conformance_", [

- testInterface.ConformanceTestInterfaceStub.prototype.validator]);

+ testInterface.ConformanceTestInterface.validateRequest]);

}

function testNotImplementedMessageValidation() {

testMessageValidation("not_implemented_", [

- testInterface.ConformanceTestInterfaceStub.prototype.validator]);

+ testInterface.ConformanceTestInterface.validateRequest]);

}

function testIntegratedMessageValidation() {

@@ -279,8 +279,8 @@ define([

var testConnection = new connection.TestConnection(

testMessagePipe.handle1,

- testInterface.IntegrationTestInterface1Stub,

- testInterface.IntegrationTestInterface2Proxy);

+ testInterface.IntegrationTestInterface1.stubClass,

+ testInterface.IntegrationTestInterface2.proxyClass);

var validationError = noError;

testConnection.router_.validationErrorHandler = function(err) {