Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Unified Diff: mojo/apps/js/main.js

Issue 628763002: Mojo JS bindings: simplify mojo.connectToService() usage - Part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed template indentation Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/apps/js/bindings/sample_service_unittests.js ('k') | mojo/apps/js/test/js_to_cpp_unittest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/apps/js/main.js
diff --git a/mojo/apps/js/main.js b/mojo/apps/js/main.js
index c8eaac5a5e655f58443b680568d9574132c9ef2d..e2562cf088f4b6ddcdaa0f8189e81e3556722341 100644
--- a/mojo/apps/js/main.js
+++ b/mojo/apps/js/main.js
@@ -22,19 +22,24 @@ define("test", [
], function(core, connection, support, net, loader, mojo, console) {
var netServiceHandle = mojo.connectToService(
- "mojo:mojo_network_service", "mojo::NetworkService");
+ "mojo:mojo_network_service", net.NetworkService.name);
var netConnection = new connection.Connection(
- netServiceHandle, net.NetworkServiceStub, net.NetworkServiceProxy);
+ netServiceHandle,
+ net.NetworkService.stubClass,
+ net.NetworkService.proxyClass);
- var urlLoaderPipe = new core.createMessagePipe();
+ var urlLoaderPipe = core.createMessagePipe();
netConnection.remote.createURLLoader(urlLoaderPipe.handle1);
var urlLoaderConnection = new connection.Connection(
- urlLoaderPipe.handle0, loader.URLLoaderStub, loader.URLLoaderProxy);
+ urlLoaderPipe.handle0,
+ loader.URLLoader.stubClass,
+ loader.URLLoader.proxyClass);
- var urlRequest = new loader.URLRequest();
- urlRequest.url = "http://www.cnn.com";
- urlRequest.method = "GET";
- urlRequest.auto_follow_redirects = true;
+ var urlRequest = new loader.URLRequest({
+ url: "http://www.cnn.com",
+ method: "GET",
+ auto_follow_redirects: true
+ });
var urlRequestPromise = urlLoaderConnection.remote.start(urlRequest);
urlRequestPromise.then(function(result) {
« no previous file with comments | « mojo/apps/js/bindings/sample_service_unittests.js ('k') | mojo/apps/js/test/js_to_cpp_unittest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698