Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 628243002: replace OVERRIDE and FINAL with override and final in jingle/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

replace OVERRIDE and FINAL with override and final in jingle/ R=hclam@chromium.org,dcheng@chromium.org BUG=417463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -176 lines) Patch
M jingle/glue/channel_socket_adapter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M jingle/glue/chrome_async_socket.h View 5 chunks +8 lines, -8 lines 0 comments Download
M jingle/glue/chrome_async_socket_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M jingle/glue/fake_ssl_client_socket.h View 1 chunk +18 lines, -18 lines 0 comments Download
M jingle/glue/proxy_resolving_client_socket.h View 1 chunk +18 lines, -18 lines 0 comments Download
M jingle/glue/pseudotcp_adapter.h View 1 chunk +18 lines, -18 lines 0 comments Download
M jingle/glue/pseudotcp_adapter.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M jingle/glue/pseudotcp_adapter_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M jingle/glue/task_pump.h View 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/glue/thread_wrapper.h View 1 chunk +16 lines, -16 lines 0 comments Download
M jingle/glue/thread_wrapper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/xmpp_client_socket_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/notifier/base/fake_base_task.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/gaia_token_pre_xmpp_auth.h View 1 chunk +10 lines, -10 lines 0 comments Download
M jingle/notifier/base/gaia_token_pre_xmpp_auth.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/weak_xmpp_client.h View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/communicator/login.h View 1 chunk +7 lines, -7 lines 0 comments Download
M jingle/notifier/communicator/single_login_attempt.h View 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/notifier/communicator/single_login_attempt_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M jingle/notifier/listener/fake_push_client.h View 1 chunk +6 lines, -6 lines 0 comments Download
M jingle/notifier/listener/fake_push_client_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M jingle/notifier/listener/non_blocking_push_client.h View 1 chunk +6 lines, -6 lines 0 comments Download
M jingle/notifier/listener/non_blocking_push_client.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M jingle/notifier/listener/non_blocking_push_client_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M jingle/notifier/listener/push_notifications_listen_task.h View 1 chunk +3 lines, -3 lines 0 comments Download
M jingle/notifier/listener/push_notifications_send_update_task.h View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/push_notifications_subscribe_task.h View 1 chunk +3 lines, -3 lines 0 comments Download
M jingle/notifier/listener/send_ping_task.h View 1 chunk +3 lines, -3 lines 0 comments Download
M jingle/notifier/listener/xmpp_push_client.h View 1 chunk +13 lines, -13 lines 0 comments Download
M jingle/notifier/listener/xmpp_push_client_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mostyn Bramley-Moore
@Alpha: can you give this a thumbs-up? The script I used to make this change ...
6 years, 2 months ago (2014-10-06 14:35:44 UTC) #1
Alpha Left Google
LGTM.
6 years, 2 months ago (2014-10-06 18:10:27 UTC) #2
Mostyn Bramley-Moore
6 years, 2 months ago (2014-10-06 18:58:53 UTC) #3
Looks like https://codereview.chromium.org/628123002/ is already in the queue,
closing this.

Powered by Google App Engine
This is Rietveld 408576698