Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 625933003: Consolidated checks for the PaintBehaviorRenderingSVGMask flag (Closed)

Created:
6 years, 2 months ago by fs
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, rune+blink, Stephen Chennney, zoltan1
Project:
blink
Visibility:
Public.

Description

Consolidated checks for the PaintBehaviorRenderingSVGMask flag Move various (more or less) open-coded checks of the PaintBehaviorRenderingSVGMask flag to SVGRenderSupport, and call the new function instead. BUG=420022 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183250

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -25 lines) Patch
M Source/core/rendering/svg/RenderSVGResource.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceSolidColor.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.h View 1 chunk +4 lines, -1 line 2 comments Download
M Source/core/rendering/svg/SVGRenderSupport.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.cpp View 3 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
6 years, 2 months ago (2014-10-03 16:29:03 UTC) #2
pdr.
LGTM. Looking forward to how this project goes :) https://codereview.chromium.org/625933003/diff/1/Source/core/rendering/svg/SVGRenderSupport.h File Source/core/rendering/svg/SVGRenderSupport.h (right): https://codereview.chromium.org/625933003/diff/1/Source/core/rendering/svg/SVGRenderSupport.h#newcode57 Source/core/rendering/svg/SVGRenderSupport.h:57: ...
6 years, 2 months ago (2014-10-03 17:06:58 UTC) #3
fs
https://codereview.chromium.org/625933003/diff/1/Source/core/rendering/svg/SVGRenderSupport.h File Source/core/rendering/svg/SVGRenderSupport.h (right): https://codereview.chromium.org/625933003/diff/1/Source/core/rendering/svg/SVGRenderSupport.h#newcode57 Source/core/rendering/svg/SVGRenderSupport.h:57: static bool isRenderingMaskImage(const RenderObject&); On 2014/10/03 17:06:58, pdr wrote: ...
6 years, 2 months ago (2014-10-06 08:00:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/625933003/1
6 years, 2 months ago (2014-10-06 08:00:34 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 08:04:22 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183250

Powered by Google App Engine
This is Rietveld 408576698