Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: android_webview/native/permission/permission_request_handler_unittest.cc

Issue 623833003: replace OVERRIDE and FINAL with override and final in android_webview/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/permission/aw_permission_request.h" 5 #include "android_webview/native/permission/aw_permission_request.h"
6 #include "android_webview/native/permission/aw_permission_request_delegate.h" 6 #include "android_webview/native/permission/aw_permission_request_delegate.h"
7 #include "android_webview/native/permission/permission_request_handler.h" 7 #include "android_webview/native/permission/permission_request_handler.h"
8 #include "android_webview/native/permission/permission_request_handler_client.h" 8 #include "android_webview/native/permission/permission_request_handler_client.h"
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
12 12
13 namespace android_webview { 13 namespace android_webview {
14 14
15 class TestAwPermissionRequestDelegate : public AwPermissionRequestDelegate { 15 class TestAwPermissionRequestDelegate : public AwPermissionRequestDelegate {
16 public: 16 public:
17 TestAwPermissionRequestDelegate( 17 TestAwPermissionRequestDelegate(
18 const GURL& origin, int64 resources, base::Callback<void(bool)> callback) 18 const GURL& origin, int64 resources, base::Callback<void(bool)> callback)
19 : origin_(origin), 19 : origin_(origin),
20 resources_(resources), 20 resources_(resources),
21 callback_(callback) {} 21 callback_(callback) {}
22 22
23 // Get the origin which initiated the permission request. 23 // Get the origin which initiated the permission request.
24 virtual const GURL& GetOrigin() OVERRIDE { 24 virtual const GURL& GetOrigin() override {
25 return origin_; 25 return origin_;
26 } 26 }
27 27
28 // Get the resources the origin wanted to access. 28 // Get the resources the origin wanted to access.
29 virtual int64 GetResources() OVERRIDE { 29 virtual int64 GetResources() override {
30 return resources_; 30 return resources_;
31 } 31 }
32 32
33 // Notify the permission request is allowed or not. 33 // Notify the permission request is allowed or not.
34 virtual void NotifyRequestResult(bool allowed) OVERRIDE { 34 virtual void NotifyRequestResult(bool allowed) override {
35 callback_.Run(allowed); 35 callback_.Run(allowed);
36 } 36 }
37 37
38 private: 38 private:
39 GURL origin_; 39 GURL origin_;
40 int64 resources_; 40 int64 resources_;
41 base::Callback<void(bool)> callback_; 41 base::Callback<void(bool)> callback_;
42 }; 42 };
43 43
44 class TestPermissionRequestHandlerClient : 44 class TestPermissionRequestHandlerClient :
45 public PermissionRequestHandlerClient { 45 public PermissionRequestHandlerClient {
46 public: 46 public:
47 struct Permission { 47 struct Permission {
48 Permission() 48 Permission()
49 :resources(0) {} 49 :resources(0) {}
50 Permission(const GURL& origin, int64 resources) 50 Permission(const GURL& origin, int64 resources)
51 : origin(origin), 51 : origin(origin),
52 resources(resources) {} 52 resources(resources) {}
53 GURL origin; 53 GURL origin;
54 int64 resources; 54 int64 resources;
55 }; 55 };
56 56
57 TestPermissionRequestHandlerClient() 57 TestPermissionRequestHandlerClient()
58 : request_(NULL) {} 58 : request_(NULL) {}
59 59
60 virtual void OnPermissionRequest(AwPermissionRequest* request) OVERRIDE { 60 virtual void OnPermissionRequest(AwPermissionRequest* request) override {
61 request_ = request; 61 request_ = request;
62 requested_permission_ = 62 requested_permission_ =
63 Permission(request->GetOrigin(), request->GetResources()); 63 Permission(request->GetOrigin(), request->GetResources());
64 } 64 }
65 65
66 virtual void OnPermissionRequestCanceled( 66 virtual void OnPermissionRequestCanceled(
67 AwPermissionRequest* request) OVERRIDE{ 67 AwPermissionRequest* request) override{
68 canceled_permission_ = 68 canceled_permission_ =
69 Permission(request->GetOrigin(), request->GetResources()); 69 Permission(request->GetOrigin(), request->GetResources());
70 } 70 }
71 71
72 AwPermissionRequest* request() { 72 AwPermissionRequest* request() {
73 return request_; 73 return request_;
74 } 74 }
75 75
76 const Permission& requested_permission() { 76 const Permission& requested_permission() {
77 return requested_permission_; 77 return requested_permission_;
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 public: 122 public:
123 PermissionRequestHandlerTest() 123 PermissionRequestHandlerTest()
124 : handler_(&client_), 124 : handler_(&client_),
125 allowed_(false) {} 125 allowed_(false) {}
126 126
127 void NotifyRequestResult(bool allowed) { 127 void NotifyRequestResult(bool allowed) {
128 allowed_ = allowed; 128 allowed_ = allowed;
129 } 129 }
130 130
131 protected: 131 protected:
132 virtual void SetUp() OVERRIDE { 132 virtual void SetUp() override {
133 testing::Test::SetUp(); 133 testing::Test::SetUp();
134 origin_ = GURL("http://www.google.com"); 134 origin_ = GURL("http://www.google.com");
135 resources_ = 135 resources_ =
136 AwPermissionRequest::VideoCapture | AwPermissionRequest::AudioCapture; 136 AwPermissionRequest::VideoCapture | AwPermissionRequest::AudioCapture;
137 delegate_.reset( 137 delegate_.reset(
138 new TestAwPermissionRequestDelegate( 138 new TestAwPermissionRequestDelegate(
139 origin_, resources_, base::Bind( 139 origin_, resources_, base::Bind(
140 &PermissionRequestHandlerTest::NotifyRequestResult, 140 &PermissionRequestHandlerTest::NotifyRequestResult,
141 base::Unretained(this)))); 141 base::Unretained(this))));
142 } 142 }
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
343 delegate.reset(new TestAwPermissionRequestDelegate( 343 delegate.reset(new TestAwPermissionRequestDelegate(
344 origin_hostname, AwPermissionRequest::Geolocation, 344 origin_hostname, AwPermissionRequest::Geolocation,
345 base::Bind(&PermissionRequestHandlerTest::NotifyRequestResult, 345 base::Bind(&PermissionRequestHandlerTest::NotifyRequestResult,
346 base::Unretained(this)))); 346 base::Unretained(this))));
347 handler()->SendRequest(delegate.Pass()); 347 handler()->SendRequest(delegate.Pass());
348 EXPECT_TRUE(allowed()); 348 EXPECT_TRUE(allowed());
349 EXPECT_EQ(NULL, client()->request()); 349 EXPECT_EQ(NULL, client()->request());
350 } 350 }
351 351
352 } // android_webview 352 } // android_webview
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698