Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: chrome/chrome_android.gypi

Issue 623403002: Generate ChromeVersionConstants.java at build time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_android.gypi
diff --git a/chrome/chrome_android.gypi b/chrome/chrome_android.gypi
index a1ec31a754a940392b0ce605b1a99a536d7391fd..b69610ea95f0cd25c4658819faad4caac20bb496 100644
--- a/chrome/chrome_android.gypi
+++ b/chrome/chrome_android.gypi
@@ -51,5 +51,58 @@
],
},
},
+ {
+ 'target_name': 'chrome_version_java',
+ 'type': 'none',
+ 'variables': {
+ 'template_input_path': 'android/java/ChromeVersionConstants.java.version',
+ 'version_path': 'VERSION',
+ 'version_py_path': '<(DEPTH)/build/util/version.py',
+ 'output_path': '<(SHARED_INTERMEDIATE_DIR)/templates/org/chromium/chrome/browser/ChromeVersionConstants.java',
+
+ 'conditions': [
+ ['branding == "Chrome"', {
+ 'branding_path': 'app/theme/google_chrome/BRANDING',
+ }, {
+ 'branding_path': 'app/theme/chromium/BRANDING',
+ }],
+ ],
+ },
+ 'direct_dependent_settings': {
+ 'variables': {
+ # Ensure that the output directory is used in the class path
+ # when building targets that depend on this one.
+ 'generated_src_dirs': [
+ '<(SHARED_INTERMEDIATE_DIR)/templates',
newt (away) 2014/10/09 21:53:04 Chris, do you think putting the generated Java fil
cjhopman 2014/10/09 22:07:29 Yeah, that would do it. I see that we do this othe
+ ],
+ # Ensure dependents are rebuilt when the generated Java file changes.
+ 'additional_input_paths': [
+ '<(output_path)',
+ ],
+ },
+ },
+ 'actions': [
+ {
+ 'action_name': 'chrome_version_java_template',
+ 'inputs': [
+ '<(template_input_path)',
+ '<(version_path)',
+ '<(branding_path)',
+ '<(version_py_path)',
+ ],
+ 'outputs': [
+ '<(output_path)',
+ ],
+ 'action': [
+ 'python',
+ '<(version_py_path)',
+ '-f', '<(version_path)',
+ '-f', '<(branding_path)',
+ '<(template_input_path)',
+ '<(output_path)',
+ ],
+ },
+ ],
+ },
],
}

Powered by Google App Engine
This is Rietveld 408576698