chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java - Issue 623403002: Generate ChromeVersionConstants.java at build time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java

Issue 623403002: Generate ChromeVersionConstants.java at build time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/ChromeVersionConstants.java.version ('K') | « chrome/android/java/ChromeVersionConstants.java.version ('k') | chrome/android/java/src/org/chromium/chrome/browser/ChromeVersionInfo.java » ('j') | chrome/chrome_android.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java b/chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java

index cd332ef162947875b2f50cf111be4e79fa9f1597..3169c73676f0fc8e0021551729355c544a010bc5 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java

@@ -15,8 +15,6 @@ public class BrowserVersion {

* This function depends on the native library being loaded; calling it before then will crash.

public static boolean isOfficialBuild() {

- return nativeIsOfficialBuild();

+ return ChromeVersionConstants.IS_OFFICIAL_BUILD;

}

- private static native boolean nativeIsOfficialBuild();

}