Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: chrome/chrome_android.gypi

Issue 623403002: Generate ChromeVersionConstants.java at build time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'variables': { 5 'variables': {
6 'chromium_code': 1, 6 'chromium_code': 1,
7 'conditions': [ 7 'conditions': [
8 ['component != "shared_library" and target_arch != "arm64" and target_arch != "x64" and profiling_full_stack_frames != 1', { 8 ['component != "shared_library" and target_arch != "arm64" and target_arch != "x64" and profiling_full_stack_frames != 1', {
9 # Only enable the chromium linker on regular builds, since the 9 # Only enable the chromium linker on regular builds, since the
10 # component build crashes on Android 4.4. See b/11379966 10 # component build crashes on Android 4.4. See b/11379966
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 'app/chrome_main_delegate.cc', 44 'app/chrome_main_delegate.cc',
45 'app/chrome_main_delegate.h', 45 'app/chrome_main_delegate.h',
46 ], 46 ],
47 'link_settings': { 47 'link_settings': {
48 'libraries': [ 48 'libraries': [
49 '-landroid', 49 '-landroid',
50 '-ljnigraphics', 50 '-ljnigraphics',
51 ], 51 ],
52 }, 52 },
53 }, 53 },
54 {
55 'target_name': 'chrome_version_java',
56 'type': 'none',
57 'variables': {
58 'template_input_path': 'android/java/ChromeVersionConstants.java.version ',
59 'version_path': 'VERSION',
60 'version_py_path': '<(DEPTH)/build/util/version.py',
61 'output_path': '<(SHARED_INTERMEDIATE_DIR)/templates/org/chromium/chrome /browser/ChromeVersionConstants.java',
62
63 'conditions': [
64 ['branding == "Chrome"', {
65 'branding_path': 'app/theme/google_chrome/BRANDING',
66 }, {
67 'branding_path': 'app/theme/chromium/BRANDING',
68 }],
69 ],
70 },
71 'direct_dependent_settings': {
72 'variables': {
73 # Ensure that the output directory is used in the class path
74 # when building targets that depend on this one.
75 'generated_src_dirs': [
76 '<(SHARED_INTERMEDIATE_DIR)/templates',
newt (away) 2014/10/09 21:53:04 Chris, do you think putting the generated Java fil
cjhopman 2014/10/09 22:07:29 Yeah, that would do it. I see that we do this othe
77 ],
78 # Ensure dependents are rebuilt when the generated Java file changes.
79 'additional_input_paths': [
80 '<(output_path)',
81 ],
82 },
83 },
84 'actions': [
85 {
86 'action_name': 'chrome_version_java_template',
87 'inputs': [
88 '<(template_input_path)',
89 '<(version_path)',
90 '<(branding_path)',
91 '<(version_py_path)',
92 ],
93 'outputs': [
94 '<(output_path)',
95 ],
96 'action': [
97 'python',
98 '<(version_py_path)',
99 '-f', '<(version_path)',
100 '-f', '<(branding_path)',
101 '<(template_input_path)',
102 '<(output_path)',
103 ],
104 },
105 ],
106 },
54 ], 107 ],
55 } 108 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698