[Android] Move CommandLine.java to base

[Android] Move CommandLine.java to base

The native CommandLine lives in base, and so too should the Java wrapper. Move
CommandLine.java to base, updating all references and factoring out previously
contained switches to BaseSwitches and ContentSwitches.

BUG=320747
TBR=ajwong@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236113

[jdduke (slow), 2013-11-18 19:04:21]

bulach@: PTAL. If you think this looks reasonable I'll move forward with further
OWNER review, and rebase https://codereview.chromium.org/62833002/ accordingly.

[bulach, 2013-11-18 19:25:52]

lgtm, thanks! I have small comments below, feel free to go once bots and other
owners are happy..

+aberent as we were just talking about command line being in base rather than
content..

https://codereview.chromium.org/62333025/diff/1/base/android/java/src/org/chr...
File base/android/java/src/org/chromium/base/CommandLine.java (right):

https://codereview.chromium.org/62333025/diff/1/base/android/java/src/org/chr...
base/android/java/src/org/chromium/base/CommandLine.java:24: * adb shell "echo
chrome --my-param > /data/local/chrome-command-line"
nit: this needs updating.. :)

something like:

/**
 * Java mirror of base/command_line.h.
 * Android applications doesn't have command line arguments,
 * so it's "simulated" by using a file at a specific location
 * that is read very early during startup.
 * Applications will define their own files,
 * see ContentShellActivity.COMMAND_LINE_FILE
 * or ChromiumTestShellApplication.COMMAND_LINE_FILE
**/

https://codereview.chromium.org/62333025/diff/1/base/android/java/src/org/chr...
base/android/java/src/org/chromium/base/CommandLine.java:26: public abstract
class CommandLine {
this one probably needs moving as well:
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/and...

https://codereview.chromium.org/62333025/diff/1/content/public/android/javate...
File
content/public/android/javatests/src/org/chromium/content/browser/CommandLineTest.java
(right):

https://codereview.chromium.org/62333025/diff/1/content/public/android/javate...
content/public/android/javatests/src/org/chromium/content/browser/CommandLineTest.java:18:
public class CommandLineTest extends InstrumentationTestCase {
as above, this file show be in base/ now..

[jdduke (slow), 2013-11-18 19:53:33]

https://codereview.chromium.org/62333025/diff/1/base/android/java/src/org/chr...
File base/android/java/src/org/chromium/base/CommandLine.java (right):

https://codereview.chromium.org/62333025/diff/1/base/android/java/src/org/chr...
base/android/java/src/org/chromium/base/CommandLine.java:24: * adb shell "echo
chrome --my-param > /data/local/chrome-command-line"
On 2013/11/18 19:25:53, bulach wrote:
> nit: this needs updating.. :)
> 
> something like:
> 
> /**
>  * Java mirror of base/command_line.h.
>  * Android applications doesn't have command line arguments,
>  * so it's "simulated" by using a file at a specific location
>  * that is read very early during startup.
>  * Applications will define their own files,
>  * see ContentShellActivity.COMMAND_LINE_FILE
>  * or ChromiumTestShellApplication.COMMAND_LINE_FILE
> **/

Done.

https://codereview.chromium.org/62333025/diff/1/content/public/android/javate...
File
content/public/android/javatests/src/org/chromium/content/browser/CommandLineTest.java
(right):

https://codereview.chromium.org/62333025/diff/1/content/public/android/javate...
content/public/android/javatests/src/org/chromium/content/browser/CommandLineTest.java:18:
public class CommandLineTest extends InstrumentationTestCase {
On 2013/11/18 19:25:53, bulach wrote:
> as above, this file show be in base/ now..

Yeah, I was about to do that but noticed that there's quite a bit of
content-specific testing in this class.. Perhaps I should separate the basic
tests that are independent of content/?

[jdduke (slow), 2013-11-18 20:02:33]

PTAL.

boliu@: android_webview/
brettw@: base/base.gyp{i}, content/content_common.gypi

[boliu, 2013-11-18 20:51:57]

On 2013/11/18 20:02:33, jdduke wrote:
> PTAL.
> 
> boliu@: android_webview/

lgtm

> brettw@: base/base.gyp{i}, content/content_common.gypi

[bulach, 2013-11-19 12:18:08]

still lgtm w/ nit:

https://codereview.chromium.org/62333025/diff/70001/base/android/javatests/sr...
File base/android/javatests/src/org/chromium/base/CommandLineTest.java (right):

https://codereview.chromium.org/62333025/diff/70001/base/android/javatests/sr...
base/android/javatests/src/org/chromium/base/CommandLineTest.java:32: private
static boolean sInitialized = false;
nit: looks unused?

[jdduke (slow), 2013-11-19 16:32:56]

https://codereview.chromium.org/62333025/diff/70001/base/android/javatests/sr...
File base/android/javatests/src/org/chromium/base/CommandLineTest.java (right):

https://codereview.chromium.org/62333025/diff/70001/base/android/javatests/sr...
base/android/javatests/src/org/chromium/base/CommandLineTest.java:32: private
static boolean sInitialized = false;
On 2013/11/19 12:18:09, bulach wrote:
> nit: looks unused?

Done, good catch.

[jdduke (slow), 2013-11-19 18:54:47]

PTAL for owner review, thanks.

piman@: content/content_common.gypi
ajwong@: base/base.gyp{i}

[piman, 2013-11-19 20:38:19]

gyp changes LGTM

[commit-bot: I haz the power, 2013-11-19 21:28:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/62333025/290001

[awong, 2013-11-20 01:26:40]

base LGTM

[commit-bot: I haz the power, 2013-11-20 03:01:11]

Change committed as 236113

[benm (inactive), 2013-11-20 15:21:21]

https://codereview.chromium.org/62333025/diff/290001/base/base.gypi
File base/base.gypi (right):

https://codereview.chromium.org/62333025/diff/290001/base/base.gypi#newcode42
base/base.gypi:42: 'android/command_line.cc',
This new file has the same basename as the one on line 115, and so GYP is
failing downstream for Android WebView. I'm not sure why the AOSP bot didn't
catch this... I think because the bots don't run with gyp in check syntax mode
mode (http://code.google.com/p/chromium/issues/detail?id=228889)

2013-11-20 15:08:51:Updating projects from gyp files...
2013-11-20 15:08:51:static library /.../base/base.gyp:base#target has several
files with the same basename:
2013-11-20 15:08:51:  command_line: android/command_line.cc command_line.cc
2013-11-20 15:08:51:Some build systems, e.g. MSVC08, cannot handle that.

[jdduke (slow), 2013-11-20 15:31:15]

On 2013/11/20 15:21:21, benm wrote:
> https://codereview.chromium.org/62333025/diff/290001/base/base.gypi
> File base/base.gypi (right):
> 
> https://codereview.chromium.org/62333025/diff/290001/base/base.gypi#newcode42
> base/base.gypi:42: 'android/command_line.cc',
> This new file has the same basename as the one on line 115, and so GYP is
> failing downstream for Android WebView. I'm not sure why the AOSP bot didn't
> catch this... I think because the bots don't run with gyp in check syntax mode
> mode (http://code.google.com/p/chromium/issues/detail?id=228889)
> 
> 2013-11-20 15:08:51:Updating projects from gyp files...
> 2013-11-20 15:08:51:static library /.../base/base.gyp:base#target has several
> files with the same basename:
> 2013-11-20 15:08:51:  command_line: android/command_line.cc command_line.cc
> 2013-11-20 15:08:51:Some build systems, e.g. MSVC08, cannot handle that.

Right, fix is here https://codereview.chromium.org/77473002/