Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: base/android/java/src/org/chromium/base/CommandLine.java

Issue 62333025: [Android] Move CommandLine.java to base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/java/src/org/chromium/base/CommandLine.java
diff --git a/content/public/android/java/src/org/chromium/content/common/CommandLine.java b/base/android/java/src/org/chromium/base/CommandLine.java
similarity index 81%
rename from content/public/android/java/src/org/chromium/content/common/CommandLine.java
rename to base/android/java/src/org/chromium/base/CommandLine.java
index be33eccfa34f8b5fc5e8f0c85fb48acd84b6ec40..f4f0b1d509ca3a33d30b0dc33260e9e6c53e5e56 100644
--- a/content/public/android/java/src/org/chromium/content/common/CommandLine.java
+++ b/base/android/java/src/org/chromium/base/CommandLine.java
@@ -1,8 +1,8 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-package org.chromium.content.common;
+package org.chromium.base;
import android.text.TextUtils;
import android.util.Log;
@@ -19,72 +19,12 @@ import java.util.HashMap;
import java.util.concurrent.atomic.AtomicReference;
/**
- * Java mirror of Chrome command-line utilities (e.g. class CommandLine from base/command_line.h).
- * Command line program adb_command_line can be used to set the Chrome command line:
- * adb shell "echo chrome --my-param > /data/local/chrome-command-line"
- */
+ * Java mirror of base/command_line.h.
+ * Android applications don't have command line arguments. Instead, they're "simulated" by reading a
+ * file at a specific location early during startup. Applications each define their own files, e.g.,
+ * ContentShellActivity.COMMAND_LINE_FILE or ChromiumTestShellApplication.COMMAND_LINE_FILE.
+**/
public abstract class CommandLine {
- // Block onCreate() of Chrome until a Java debugger is attached.
- public static final String WAIT_FOR_JAVA_DEBUGGER = "wait-for-java-debugger";
-
- // Tell Java to use the official command line, loaded from the
- // official-command-line.xml files. WARNING this is not done
- // immediately on startup, so early running Java code will not see
- // these flags.
- public static final String ADD_OFFICIAL_COMMAND_LINE = "add-official-command-line";
-
- // Enables test intent handling.
- public static final String ENABLE_TEST_INTENTS = "enable-test-intents";
-
- // Adds additional thread idle time information into the trace event output.
- public static final String ENABLE_IDLE_TRACING = "enable-idle-tracing";
-
- // Dump frames-per-second to the log
- public static final String LOG_FPS = "log-fps";
-
- // Whether Chromium should use a mobile user agent.
- public static final String USE_MOBILE_UA = "use-mobile-user-agent";
-
- // tablet specific UI components.
- // Native switch - chrome_switches::kTabletUI
- public static final String TABLET_UI = "tablet-ui";
-
- // Change the url of the JavaScript that gets injected when accessibility mode is enabled.
- public static final String ACCESSIBILITY_JAVASCRIPT_URL = "accessibility-js-url";
-
- public static final String ACCESSIBILITY_DEBUG_BRAILLE_SERVICE = "debug-braille-service";
-
- // Sets the ISO country code that will be used for phone number detection.
- public static final String NETWORK_COUNTRY_ISO = "network-country-iso";
-
- // Whether to enable the auto-hiding top controls.
- public static final String ENABLE_TOP_CONTROLS_POSITION_CALCULATION
- = "enable-top-controls-position-calculation";
-
- // The height of the movable top controls.
- public static final String TOP_CONTROLS_HEIGHT = "top-controls-height";
-
- // How much of the top controls need to be shown before they will auto show.
- public static final String TOP_CONTROLS_SHOW_THRESHOLD = "top-controls-show-threshold";
-
- // How much of the top controls need to be hidden before they will auto hide.
- public static final String TOP_CONTROLS_HIDE_THRESHOLD = "top-controls-hide-threshold";
-
- // Native switch - chrome_switches::kEnableInstantExtendedAPI
- public static final String ENABLE_INSTANT_EXTENDED_API = "enable-instant-extended-api";
-
- // Native switch - content_switches::kEnableSpeechRecognition
- public static final String ENABLE_SPEECH_RECOGNITION = "enable-speech-recognition";
-
- // Native switch - shell_switches::kDumpRenderTree
- public static final String DUMP_RENDER_TREE = "dump-render-tree";
-
- // Native switch - chrome_switches::kDisablePopupBlocking
- public static final String DISABLE_POPUP_BLOCKING = "disable-popup-blocking";
-
- // Whether to disable the click delay by sending click events during double tap
- public static final String DISABLE_CLICK_DELAY = "disable-click-delay";
-
// Public abstract interface, implemented in derived classes.
// All these methods reflect their native-side counterparts.
/**

Powered by Google App Engine
This is Rietveld 408576698