Issue 62333002: Handlify Runtime::SetObjectProperty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 62333002: Handlify Runtime::SetObjectProperty (Closed)

Created:
7 years, 1 month ago by rafaelw

Modified:
7 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handlify Runtime::SetObjectProperty BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17560

Patch Set 3 : whitespace #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -173 lines)			Patch
M	src/api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/handles.h	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/handles.cc	View	1 2	1 chunk	+0 lines, -14 lines	0 comments	Download
M	src/ic.cc	View		5 chunks	+31 lines, -22 lines	0 comments	Download
M	src/runtime.h	View		1 chunk	+1 line, -9 lines	0 comments	Download
M	src/runtime.cc	View	1	15 chunks	+79 lines, -107 lines	0 comments	Download
M	src/scopeinfo.cc	View		1 chunk	+7 lines, -8 lines	0 comments	Download
M	test/cctest/test-compiler.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	test/cctest/test-debug.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/62333002/diff/30001/src/handles.cc File src/handles.cc (right): https://codereview.chromium.org/62333002/diff/30001/src/handles.cc#newcode161 src/handles.cc:161: nit: Two empty newlines between top-level methods.

7 years, 1 month ago (2013-11-07 12:21:46 UTC) #2

rafaelw

Committed patchset #3 manually as r17560 (presubmit successful).

7 years, 1 month ago (2013-11-07 12:36:09 UTC) #3

rafaelw

7 years, 1 month ago (2013-11-07 12:37:06 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/62333002/diff/30001/src/handles.cc
File src/handles.cc (right):

https://codereview.chromium.org/62333002/diff/30001/src/handles.cc#newcode161
src/handles.cc:161: 
On 2013/11/07 12:21:46, Michael Starzinger wrote:
> nit: Two empty newlines between top-level methods.

Done.

Expand Messages | Collapse Messages

Issue 62333002: Handlify Runtime::SetObjectProperty (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : whitespace #

Messages