Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/handles.cc

Issue 62333002: Handlify Runtime::SetObjectProperty (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: fix Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/handles.h ('k') | src/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 151
152 152
153 void FlattenString(Handle<String> string) { 153 void FlattenString(Handle<String> string) {
154 CALL_HEAP_FUNCTION_VOID(string->GetIsolate(), string->TryFlatten()); 154 CALL_HEAP_FUNCTION_VOID(string->GetIsolate(), string->TryFlatten());
155 } 155 }
156 156
157 157
158 Handle<String> FlattenGetString(Handle<String> string) { 158 Handle<String> FlattenGetString(Handle<String> string) {
159 CALL_HEAP_FUNCTION(string->GetIsolate(), string->TryFlatten(), String); 159 CALL_HEAP_FUNCTION(string->GetIsolate(), string->TryFlatten(), String);
160 } 160 }
161 161
Michael Starzinger 2013/11/07 12:21:46 nit: Two empty newlines between top-level methods.
rafaelw 2013/11/07 12:37:06 Done.
162
163 Handle<Object> SetProperty(Isolate* isolate,
164 Handle<Object> object,
165 Handle<Object> key,
166 Handle<Object> value,
167 PropertyAttributes attributes,
168 StrictModeFlag strict_mode) {
169 CALL_HEAP_FUNCTION(
170 isolate,
171 Runtime::SetObjectProperty(
172 isolate, object, key, value, attributes, strict_mode),
173 Object);
174 }
175
176
177 Handle<Object> ForceSetProperty(Handle<JSObject> object, 162 Handle<Object> ForceSetProperty(Handle<JSObject> object,
178 Handle<Object> key, 163 Handle<Object> key,
179 Handle<Object> value, 164 Handle<Object> value,
180 PropertyAttributes attributes) { 165 PropertyAttributes attributes) {
181 return Runtime::ForceSetObjectProperty(object->GetIsolate(), object, key, 166 return Runtime::ForceSetObjectProperty(object->GetIsolate(), object, key,
182 value, attributes); 167 value, attributes);
183 } 168 }
184 169
185 170
186 Handle<Object> DeleteProperty(Handle<JSObject> object, Handle<Object> key) { 171 Handle<Object> DeleteProperty(Handle<JSObject> object, Handle<Object> key) {
(...skipping 622 matching lines...) Expand 10 before | Expand all | Expand 10 after
809 Handle<Code> code) { 794 Handle<Code> code) {
810 heap->EnsureWeakObjectToCodeTable(); 795 heap->EnsureWeakObjectToCodeTable();
811 Handle<DependentCode> dep(heap->LookupWeakObjectToCodeDependency(*object)); 796 Handle<DependentCode> dep(heap->LookupWeakObjectToCodeDependency(*object));
812 dep = DependentCode::Insert(dep, DependentCode::kWeaklyEmbeddedGroup, code); 797 dep = DependentCode::Insert(dep, DependentCode::kWeaklyEmbeddedGroup, code);
813 CALL_HEAP_FUNCTION_VOID(heap->isolate(), 798 CALL_HEAP_FUNCTION_VOID(heap->isolate(),
814 heap->AddWeakObjectToCodeDependency(*object, *dep)); 799 heap->AddWeakObjectToCodeDependency(*object, *dep));
815 } 800 }
816 801
817 802
818 } } // namespace v8::internal 803 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/handles.h ('k') | src/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698