Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/api.cc

Issue 62333002: Handlify Runtime::SetObjectProperty (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: whitespace Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/handles.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3118 matching lines...) Expand 10 before | Expand all | Expand 10 after
3129 bool v8::Object::Set(v8::Handle<Value> key, v8::Handle<Value> value, 3129 bool v8::Object::Set(v8::Handle<Value> key, v8::Handle<Value> value,
3130 v8::PropertyAttribute attribs) { 3130 v8::PropertyAttribute attribs) {
3131 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate(); 3131 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate();
3132 ON_BAILOUT(isolate, "v8::Object::Set()", return false); 3132 ON_BAILOUT(isolate, "v8::Object::Set()", return false);
3133 ENTER_V8(isolate); 3133 ENTER_V8(isolate);
3134 i::HandleScope scope(isolate); 3134 i::HandleScope scope(isolate);
3135 i::Handle<i::Object> self = Utils::OpenHandle(this); 3135 i::Handle<i::Object> self = Utils::OpenHandle(this);
3136 i::Handle<i::Object> key_obj = Utils::OpenHandle(*key); 3136 i::Handle<i::Object> key_obj = Utils::OpenHandle(*key);
3137 i::Handle<i::Object> value_obj = Utils::OpenHandle(*value); 3137 i::Handle<i::Object> value_obj = Utils::OpenHandle(*value);
3138 EXCEPTION_PREAMBLE(isolate); 3138 EXCEPTION_PREAMBLE(isolate);
3139 i::Handle<i::Object> obj = i::SetProperty( 3139 i::Handle<i::Object> obj = i::Runtime::SetObjectProperty(
3140 isolate, 3140 isolate,
3141 self, 3141 self,
3142 key_obj, 3142 key_obj,
3143 value_obj, 3143 value_obj,
3144 static_cast<PropertyAttributes>(attribs), 3144 static_cast<PropertyAttributes>(attribs),
3145 i::kNonStrictMode); 3145 i::kNonStrictMode);
3146 has_pending_exception = obj.is_null(); 3146 has_pending_exception = obj.is_null();
3147 EXCEPTION_BAILOUT_CHECK(isolate, false); 3147 EXCEPTION_BAILOUT_CHECK(isolate, false);
3148 return true; 3148 return true;
3149 } 3149 }
(...skipping 4428 matching lines...) Expand 10 before | Expand all | Expand 10 after
7578 Isolate* isolate = reinterpret_cast<Isolate*>(info.GetIsolate()); 7578 Isolate* isolate = reinterpret_cast<Isolate*>(info.GetIsolate());
7579 Address callback_address = 7579 Address callback_address =
7580 reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback)); 7580 reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
7581 VMState<EXTERNAL> state(isolate); 7581 VMState<EXTERNAL> state(isolate);
7582 ExternalCallbackScope call_scope(isolate, callback_address); 7582 ExternalCallbackScope call_scope(isolate, callback_address);
7583 callback(info); 7583 callback(info);
7584 } 7584 }
7585 7585
7586 7586
7587 } } // namespace v8::internal 7587 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/handles.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698