Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 623103002: replace OVERRIDE and FINAL with override and final in athena/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
Reviewers:
oshima, dcheng
CC:
chromium-reviews, extensions-reviews_chromium.org, jam, dcheng, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

replace OVERRIDE and FINAL with override and final in athena/ BUG=417463 Committed: https://crrev.com/ed6dc77f0477ac378a7a2a655464f254338cbad5 Cr-Commit-Position: refs/heads/master@{#298050}

Patch Set 1 #

Patch Set 2 : rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+533 lines, -533 lines) Patch
M athena/activity/activity_frame_view.h View 1 chunk +16 lines, -16 lines 0 comments Download
M athena/activity/activity_manager_impl.h View 1 chunk +7 lines, -7 lines 0 comments Download
M athena/activity/activity_widget_delegate.h View 1 chunk +7 lines, -7 lines 0 comments Download
M athena/content/app_activity.h View 1 2 chunks +19 lines, -19 lines 0 comments Download
M athena/content/app_activity_proxy.h View 1 chunk +17 lines, -17 lines 0 comments Download
M athena/content/app_activity_unittest.cc View 3 chunks +18 lines, -18 lines 0 comments Download
M athena/content/app_registry_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M athena/content/chrome/web_activity_helpers_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/content/content_activity_factory.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M athena/content/render_view_context_menu_impl.h View 1 chunk +10 lines, -10 lines 0 comments Download
M athena/content/shell/scheme_classifier_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/content/web_activity.h View 1 chunk +21 lines, -21 lines 0 comments Download
M athena/content/web_activity.cc View 8 chunks +15 lines, -15 lines 0 comments Download
M athena/content/web_contents_view_delegate_factory_impl.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M athena/env/athena_env_impl.cc View 9 chunks +24 lines, -24 lines 0 comments Download
M athena/extensions/athena_app_delegate_base.h View 1 chunk +6 lines, -6 lines 0 comments Download
M athena/extensions/athena_app_delegate_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/extensions/athena_app_window_client_base.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/extensions/chrome/athena_chrome_app_delegate.h View 1 chunk +6 lines, -6 lines 0 comments Download
M athena/extensions/chrome/athena_chrome_app_window_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M athena/extensions/chrome/extensions_delegate_impl.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M athena/extensions/extension_app_model_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/extensions/public/extension_app_model_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/extensions/shell/athena_shell_app_delegate.h View 1 chunk +6 lines, -6 lines 0 comments Download
M athena/extensions/shell/athena_shell_app_window_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M athena/extensions/shell/extensions_delegate_impl.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M athena/extensions/test/test_extensions_delegate.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M athena/home/app_list_view_delegate.h View 1 chunk +25 lines, -25 lines 0 comments Download
M athena/home/athena_start_page_view.h View 1 chunk +3 lines, -3 lines 0 comments Download
M athena/home/athena_start_page_view.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M athena/home/athena_start_page_view_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M athena/home/home_card_gesture_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M athena/home/home_card_impl.h View 1 chunk +13 lines, -13 lines 0 comments Download
M athena/home/home_card_impl.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M athena/home/minimized_home.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M athena/input/accelerator_manager_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
M athena/input/accelerator_manager_impl.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M athena/input/accelerator_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/input/input_manager_impl.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M athena/main/athena_content_client.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/main/athena_frame_view.h View 1 chunk +11 lines, -11 lines 0 comments Download
M athena/main/athena_launcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M athena/main/athena_main.cc View 1 7 chunks +14 lines, -14 lines 0 comments Download
M athena/main/athena_renderer_pdf_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/main/athena_renderer_pdf_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/main/athena_views_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/main/url_search_provider.h View 1 chunk +3 lines, -3 lines 0 comments Download
M athena/main/url_search_provider.cc View 5 chunks +18 lines, -18 lines 0 comments Download
M athena/resource_manager/delegate/resource_manager_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M athena/resource_manager/memory_pressure_notifier_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M athena/resource_manager/resource_manager_impl.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M athena/resource_manager/resource_manager_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M athena/screen/screen_accelerator_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/screen/screen_manager_impl.cc View 6 chunks +14 lines, -14 lines 0 comments Download
M athena/system/background_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/system/network_selector.cc View 4 chunks +17 lines, -17 lines 0 comments Download
M athena/system/orientation_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/system/power_button_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/system/status_icon_container_view.h View 1 chunk +3 lines, -3 lines 0 comments Download
M athena/system/status_icon_container_view.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M athena/system/system_ui_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M athena/test/base/athena_test_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/test/base/athena_unittests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M athena/test/base/sample_activity.h View 1 chunk +17 lines, -17 lines 0 comments Download
M athena/test/base/sample_activity_factory.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M athena/test/base/test_app_model_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/test/base/test_resource_manager_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/test/chrome/athena_browsertest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M athena/util/drag_handle.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/util/drag_handle_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M athena/util/fill_layout_manager.h View 1 chunk +6 lines, -6 lines 0 comments Download
M athena/virtual_keyboard/virtual_keyboard_manager_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M athena/wm/bezel_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/wm/overview_toolbar.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M athena/wm/split_view_controller.h View 1 chunk +11 lines, -11 lines 0 comments Download
M athena/wm/split_view_controller.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M athena/wm/split_view_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/wm/title_drag_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/wm/window_list_provider_impl.h View 1 chunk +10 lines, -10 lines 0 comments Download
M athena/wm/window_list_provider_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/wm/window_manager_impl.h View 2 chunks +15 lines, -15 lines 0 comments Download
M athena/wm/window_manager_impl.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M athena/wm/window_overview_mode.cc View 6 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Mostyn Bramley-Moore
@sky: can you give this a thumbs-up? The script I used to make this change ...
6 years, 2 months ago (2014-10-03 12:52:04 UTC) #2
sky
sky->oshima
6 years, 2 months ago (2014-10-03 15:21:46 UTC) #4
oshima
lgtm
6 years, 2 months ago (2014-10-03 16:28:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/623103002/20001
6 years, 2 months ago (2014-10-03 16:42:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b21bbaf0276109f6a94b13134b34ba7d0d5c8330
6 years, 2 months ago (2014-10-03 17:09:54 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-03 17:10:35 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ed6dc77f0477ac378a7a2a655464f254338cbad5
Cr-Commit-Position: refs/heads/master@{#298050}

Powered by Google App Engine
This is Rietveld 408576698