Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Side by Side Diff: athena/resource_manager/delegate/resource_manager_delegate.cc

Issue 623103002: replace OVERRIDE and FINAL with override and final in athena/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase on master Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "athena/resource_manager/public/resource_manager_delegate.h" 5 #include "athena/resource_manager/public/resource_manager_delegate.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "base/process/process_metrics.h" 11 #include "base/process/process_metrics.h"
12 12
13 namespace athena { 13 namespace athena {
14 14
15 namespace { 15 namespace {
16 // This is the minimum amount of time in milliseconds between checks for 16 // This is the minimum amount of time in milliseconds between checks for
17 // memory pressure. 17 // memory pressure.
18 const int kMemoryPressureIntervalMs = 750; 18 const int kMemoryPressureIntervalMs = 750;
19 } // namespace 19 } // namespace
20 20
21 class ResourceManagerDelegateImpl : public ResourceManagerDelegate { 21 class ResourceManagerDelegateImpl : public ResourceManagerDelegate {
22 public: 22 public:
23 ResourceManagerDelegateImpl() {} 23 ResourceManagerDelegateImpl() {}
24 virtual ~ResourceManagerDelegateImpl() {} 24 virtual ~ResourceManagerDelegateImpl() {}
25 25
26 private: 26 private:
27 virtual int GetUsedMemoryInPercent() OVERRIDE { 27 virtual int GetUsedMemoryInPercent() override {
28 base::SystemMemoryInfoKB info; 28 base::SystemMemoryInfoKB info;
29 if (!base::GetSystemMemoryInfo(&info)) { 29 if (!base::GetSystemMemoryInfo(&info)) {
30 LOG(WARNING) << "Cannot determine the free memory of the system."; 30 LOG(WARNING) << "Cannot determine the free memory of the system.";
31 return 0; 31 return 0;
32 } 32 }
33 // TODO(skuhne): Instead of adding the kernel memory pressure calculation 33 // TODO(skuhne): Instead of adding the kernel memory pressure calculation
34 // logic here, we should have a kernel mechanism similar to the low memory 34 // logic here, we should have a kernel mechanism similar to the low memory
35 // notifier in ChromeOS which offers multiple pressure states. 35 // notifier in ChromeOS which offers multiple pressure states.
36 // To track this, we have crbug.com/381196. 36 // To track this, we have crbug.com/381196.
37 37
(...skipping 16 matching lines...) Expand all
54 54
55 // Available memory is the sum of free, swap and easy reclaimable memory. 55 // Available memory is the sum of free, swap and easy reclaimable memory.
56 int available_memory = 56 int available_memory =
57 info.free + info.swap_free / kSwapWeight + file_memory; 57 info.free + info.swap_free / kSwapWeight + file_memory;
58 58
59 DCHECK(available_memory < total_memory); 59 DCHECK(available_memory < total_memory);
60 int percentage = ((total_memory - available_memory) * 100) / total_memory; 60 int percentage = ((total_memory - available_memory) * 100) / total_memory;
61 return percentage; 61 return percentage;
62 } 62 }
63 63
64 virtual int MemoryPressureIntervalInMS() OVERRIDE { 64 virtual int MemoryPressureIntervalInMS() override {
65 return kMemoryPressureIntervalMs; 65 return kMemoryPressureIntervalMs;
66 } 66 }
67 DISALLOW_COPY_AND_ASSIGN(ResourceManagerDelegateImpl); 67 DISALLOW_COPY_AND_ASSIGN(ResourceManagerDelegateImpl);
68 }; 68 };
69 69
70 // static 70 // static
71 ResourceManagerDelegate* 71 ResourceManagerDelegate*
72 ResourceManagerDelegate::CreateResourceManagerDelegate() { 72 ResourceManagerDelegate::CreateResourceManagerDelegate() {
73 return new ResourceManagerDelegateImpl; 73 return new ResourceManagerDelegateImpl;
74 } 74 }
75 75
76 } // namespace athena 76 } // namespace athena
OLDNEW
« no previous file with comments | « athena/main/url_search_provider.cc ('k') | athena/resource_manager/memory_pressure_notifier_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698