Issue 622783002: Make PromiseRejectCallback fire after end-of-turn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 622783002: Make PromiseRejectCallback fire after end-of-turn. (Closed)

Created:
6 years, 2 months ago by aandrey

Modified:
6 years, 2 months ago

Reviewers:
rossberg, Yang, yurys

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Make PromiseRejectCallback fire after end-of-turn. R=yangguo@chromium.org, yurys@chromium.org, rossberg@chromium.org LOG=Y BUG=v8:3093

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+120 lines, -110 lines)			Patch
M	include/v8.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/compiler/linkage.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/heap/heap.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/promise.js	View	7 chunks	+54 lines, -11 lines	0 comments	Download
M	src/runtime/runtime.h	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/runtime/runtime.cc	View	1 chunk	+14 lines, -20 lines	0 comments	Download
M	src/runtime/runtime-observe.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View	9 chunks	+36 lines, -56 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

yurys

6 years, 2 months ago (2014-10-02 10:02:39 UTC) #2

After discussing this offline one more time we decided to implement it in Blink.
In particular it would be easier to control the moment when unhandled rejections
are reported ("end of turn"). Closing this issue.

Expand Messages | Collapse Messages