Make PromiseRejectCallback fire after end-of-turn.

test/cctest/test-api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 17650 matching lines @@
   v8::Isolate* isolate = env->GetIsolate();
   v8::HandleScope scope(isolate);
 
   isolate->SetPromiseRejectCallback(PromiseRejectCallback);
 
   ResetPromiseStates();
 
   // Create promise p0.
   CompileRun(
       "var reject;            \n"
-      "var p0 = new Promise(   \n"
+      "var p0 = new Promise(  \n"
       "  function(res, rej) { \n"
       "    reject = rej;      \n"
       "  }                    \n"
       ");                     \n");
-  CHECK(!GetPromise("p0")->HasHandler());
   CHECK_EQ(0, promise_reject_counter);
   CHECK_EQ(0, promise_revoke_counter);
 
   // Add resolve handler (and default reject handler) to p0.
   CompileRun("var p1 = p0.then(function(){});");
-  CHECK(GetPromise("p0")->HasHandler());
-  CHECK(!GetPromise("p1")->HasHandler());
   CHECK_EQ(0, promise_reject_counter);
   CHECK_EQ(0, promise_revoke_counter);
 
   // Reject p0.
   CompileRun("reject('ppp');");
-  CHECK(GetPromise("p0")->HasHandler());
-  CHECK(!GetPromise("p1")->HasHandler());
   CHECK_EQ(1, promise_reject_counter);
   CHECK_EQ(0, promise_revoke_counter);
   CHECK_EQ(v8::kPromiseRejectWithNoHandler, reject_event);
   CHECK(GetPromise("rejected")->Equals(GetPromise("p1")));
   CHECK(RejectValue()->Equals(v8_str("ppp")));
 
   // Reject p0 again. Callback is not triggered again.
   CompileRun("reject();");
-  CHECK(GetPromise("p0")->HasHandler());
-  CHECK(!GetPromise("p1")->HasHandler());
   CHECK_EQ(1, promise_reject_counter);
   CHECK_EQ(0, promise_revoke_counter);
 
   // Add resolve handler to p1.
   CompileRun("var p2 = p1.then(function(){});");
-  CHECK(GetPromise("p0")->HasHandler());
-  CHECK(GetPromise("p1")->HasHandler());
-  CHECK(!GetPromise("p2")->HasHandler());
   CHECK_EQ(2, promise_reject_counter);
   CHECK_EQ(1, promise_revoke_counter);
   CHECK(GetPromise("rejected")->Equals(GetPromise("p2")));
   CHECK(RejectValue()->Equals(v8_str("ppp")));
   CHECK(GetPromise("revoked")->Equals(GetPromise("p1")));
 
   ResetPromiseStates();
 
   // Create promise q0.
   CompileRun(
       "var q0 = new Promise(   \n"
       "  function(res, rej) { \n"
       "    reject = rej;      \n"
       "  }                    \n"
       ");                     \n");
-  CHECK(!GetPromise("q0")->HasHandler());
   CHECK_EQ(0, promise_reject_counter);
   CHECK_EQ(0, promise_revoke_counter);
 
   // Add reject handler to q0.
   CompileRun("var q1 = q0.catch(function() {});");
-  CHECK(GetPromise("q0")->HasHandler());
-  CHECK(!GetPromise("q1")->HasHandler());
   CHECK_EQ(0, promise_reject_counter);
   CHECK_EQ(0, promise_revoke_counter);
 
   // Reject q0.
   CompileRun("reject('qq')");
-  CHECK(GetPromise("q0")->HasHandler());
-  CHECK(!GetPromise("q1")->HasHandler());
   CHECK_EQ(0, promise_reject_counter);
   CHECK_EQ(0, promise_revoke_counter);
 
   // Add a new reject handler, which rejects by returning Promise.reject().
   // The returned promise q_ triggers a reject callback at first, only to
   // revoke it when returning it causes q2 to be rejected.
   CompileRun(
       "var q_;"
       "var q2 = q0.catch(               \n"
       "   function() {                  \n"
       "     q_ = Promise.reject('qqq'); \n"
       "     return q_;                  \n"
       "   }                             \n"
       ");                               \n");
-  CHECK(GetPromise("q0")->HasHandler());
-  CHECK(!GetPromise("q1")->HasHandler());
-  CHECK(!GetPromise("q2")->HasHandler());
-  CHECK(GetPromise("q_")->HasHandler());
-  CHECK_EQ(2, promise_reject_counter);
-  CHECK_EQ(1, promise_revoke_counter);
+  CHECK_EQ(1, promise_reject_counter);
+  CHECK_EQ(0, promise_revoke_counter);
   CHECK(GetPromise("rejected")->Equals(GetPromise("q2")));
-  CHECK(GetPromise("revoked")->Equals(GetPromise("q_")));
   CHECK(RejectValue()->Equals(v8_str("qqq")));
 
   // Add a reject handler to the resolved q1, which rejects by throwing.
   CompileRun(
       "var q3 = q1.then( \n"
       "   function() {    \n"
       "     throw 'qqqq'; \n"
       "   }               \n"
       ");                 \n");
-  CHECK(GetPromise("q0")->HasHandler());
-  CHECK(GetPromise("q1")->HasHandler());
-  CHECK(!GetPromise("q2")->HasHandler());
-  CHECK(!GetPromise("q3")->HasHandler());
-  CHECK_EQ(3, promise_reject_counter);
-  CHECK_EQ(1, promise_revoke_counter);
+  CHECK_EQ(2, promise_reject_counter);
+  CHECK_EQ(0, promise_revoke_counter);
   CHECK(GetPromise("rejected")->Equals(GetPromise("q3")));
   CHECK(RejectValue()->Equals(v8_str("qqqq")));
 
   ResetPromiseStates();
 
   // Create promise r0, which has three handlers, two of which handle rejects.
   CompileRun(
       "var r0 = new Promise(             \n"
       "  function(res, rej) {            \n"
       "    reject = rej;                 \n"
       "  }                               \n"
       ");                                \n"
       "var r1 = r0.catch(function() {}); \n"
       "var r2 = r0.then(function() {});  \n"
       "var r3 = r0.then(function() {},   \n"
       "                 function() {});  \n");
-  CHECK(GetPromise("r0")->HasHandler());
-  CHECK(!GetPromise("r1")->HasHandler());
-  CHECK(!GetPromise("r2")->HasHandler());
-  CHECK(!GetPromise("r3")->HasHandler());
   CHECK_EQ(0, promise_reject_counter);
   CHECK_EQ(0, promise_revoke_counter);
 
   // Reject r0.
   CompileRun("reject('rrr')");
-  CHECK(GetPromise("r0")->HasHandler());
-  CHECK(!GetPromise("r1")->HasHandler());
-  CHECK(!GetPromise("r2")->HasHandler());
-  CHECK(!GetPromise("r3")->HasHandler());
   CHECK_EQ(1, promise_reject_counter);
   CHECK_EQ(0, promise_revoke_counter);
   CHECK(GetPromise("rejected")->Equals(GetPromise("r2")));
   CHECK(RejectValue()->Equals(v8_str("rrr")));
 
   // Add reject handler to r2.
   CompileRun("var r4 = r2.catch(function() {});");
-  CHECK(GetPromise("r0")->HasHandler());
-  CHECK(!GetPromise("r1")->HasHandler());
-  CHECK(GetPromise("r2")->HasHandler());
-  CHECK(!GetPromise("r3")->HasHandler());
-  CHECK(!GetPromise("r4")->HasHandler());
   CHECK_EQ(1, promise_reject_counter);
   CHECK_EQ(1, promise_revoke_counter);
   CHECK(GetPromise("revoked")->Equals(GetPromise("r2")));
   CHECK(RejectValue()->Equals(v8_str("rrr")));
 
   // Add reject handlers to r4.
   CompileRun("var r5 = r4.then(function() {}, function() {});");
-  CHECK(GetPromise("r0")->HasHandler());
-  CHECK(!GetPromise("r1")->HasHandler());
-  CHECK(GetPromise("r2")->HasHandler());
-  CHECK(!GetPromise("r3")->HasHandler());
-  CHECK(GetPromise("r4")->HasHandler());
-  CHECK(!GetPromise("r5")->HasHandler());
   CHECK_EQ(1, promise_reject_counter);
   CHECK_EQ(1, promise_revoke_counter);
 
   ResetPromiseStates();
 
   // Create promise s0, which has three handlers, none of which handle rejects.
   CompileRun(
       "var s0 = new Promise(            \n"
       "  function(res, rej) {           \n"
       "    reject = rej;                \n"
       "  }                              \n"
       ");                               \n"
       "var s1 = s0.then(function() {}); \n"
       "var s2 = s0.then(function() {}); \n"
       "var s3 = s0.then(function() {}); \n");
-  CHECK(GetPromise("s0")->HasHandler());
-  CHECK(!GetPromise("s1")->HasHandler());
-  CHECK(!GetPromise("s2")->HasHandler());
-  CHECK(!GetPromise("s3")->HasHandler());
   CHECK_EQ(0, promise_reject_counter);
   CHECK_EQ(0, promise_revoke_counter);
 
   // Reject s0.
   CompileRun("reject('sss')");
-  CHECK(GetPromise("s0")->HasHandler());
-  CHECK(!GetPromise("s1")->HasHandler());
-  CHECK(!GetPromise("s2")->HasHandler());
-  CHECK(!GetPromise("s3")->HasHandler());
   CHECK_EQ(3, promise_reject_counter);
   CHECK_EQ(0, promise_revoke_counter);
   CHECK(RejectValue()->Equals(v8_str("sss")));
+
+  ResetPromiseStates();
+
+  // Create promise m0, which has three handlers, which will be handled at a
+  // microtask checkpoint.
+  CompileRun(
+      "var m0 = new Promise(            \n"
+      "  function(res, rej) {           \n"
+      "    reject = rej;                \n"
+      "  }                              \n"
+      ");                               \n"
+      "var m1 = m0.then(function() {}); \n"
+      "var m2 = m0.then(function() {}); \n"
+      "var m3 = m0.then(function() {}); \n"
+      "var m4;                          \n"
+      "m0.catch(function() {            \n"
+      "  m2.catch(function() {          \n"
+      "    m1.catch(function() {        \n"
+      "      m4 = m3.then(function() {})\n"
+      "    });                          \n"
+      "  });                            \n"
+      "});                              \n");
+  CHECK_EQ(0, promise_reject_counter);
+  CHECK_EQ(0, promise_revoke_counter);
+
+  // Reject m0: m1-m3 promises should be handled at "the end of turn".
+  CompileRun("reject('mmm')");
+  CHECK_EQ(1, promise_reject_counter);
+  CHECK_EQ(0, promise_revoke_counter);
+  CHECK(GetPromise("rejected")->Equals(GetPromise("m4")));
+  CHECK(RejectValue()->Equals(v8_str("mmm")));
 }
 
 
 void AnalyzeStackOfEvalWithSourceURL(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   v8::HandleScope scope(args.GetIsolate());
   v8::Handle<v8::StackTrace> stackTrace = v8::StackTrace::CurrentStackTrace(
       args.GetIsolate(), 10, v8::StackTrace::kDetailed);
   CHECK_EQ(5, stackTrace->GetFrameCount());
   v8::Handle<v8::String> url = v8_str("eval_url");
@@ skipping 5818 matching lines @@
       "  var foobXXXXX";  // Too many bytes which look like incomplete chars!
   char chunk2[] =
       "r = 13;\n"
       "  return foob\xeb\x91\x80\x80\x80r;\n"
       "}\n";
   for (int i = 0; i < 5; ++i) chunk1[strlen(chunk1) - 5 + i] = reference[i];
 
   const char* chunks[] = {chunk1, chunk2, "foo();", NULL};
   RunStreamingTest(chunks, v8::ScriptCompiler::StreamedSource::UTF8, false);
 }