|
|
Chromium Code Reviews|
Created:
6 years, 2 months ago by Erik Corry Chromium.org Modified:
6 years, 2 months ago CC:
chromium-reviews, asvitkine+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
DescriptionAdd support for recently added Blink use counters including BreakIterator
R=peter@chromium.org
BUG=
Committed: https://crrev.com/6c3d6f54c161c3147e76e7114ece304ea88d9e26
Cr-Commit-Position: refs/heads/master@{#298020}
Patch Set 1 #Patch Set 2 : Merge up #
Messages
Total messages: 15 (5 generated)
erik.corry@gmail.com changed reviewers: + erik.corry@gmail.com
On 2014/10/01 14:00:34, Erik Corry wrote: > Related: > https://codereview.chromium.org/535733005/ > https://codereview.chromium.org/621593003/ > https://codereview.chromium.org/619913002 lgtm, but (1) please wait until the Blink patch lands before submitting, and (2) find an OWNER too :-).
erikcorry@chromium.org changed reviewers: + asvitkine@chromium.org
On 2014/10/01 14:04:27, Peter Beverloo wrote: > On 2014/10/01 14:00:34, Erik Corry wrote: > > Related: > > https://codereview.chromium.org/535733005/ > > https://codereview.chromium.org/621593003/ > > https://codereview.chromium.org/619913002 > > lgtm, but (1) please wait until the Blink patch lands before submitting, and (2) > find an OWNER too :-). Blink patch has now landed: https://codereview.chromium.org/621593003/ Alexei has been added as reviewer.
The CQ bit was checked by asvitkine@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622543003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/63720) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/68552) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...) android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...) android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...) win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by erikcorry@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622543003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 15d5caa51d857cda3bce3227754c168ba81e5b44
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6c3d6f54c161c3147e76e7114ece304ea88d9e26 Cr-Commit-Position: refs/heads/master@{#298020} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
