Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 621593003: Prepare to add a use counter for Intl.v8BreakIterator (Closed)

Created:
6 years, 2 months ago by Erik Corry Chromium.org
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Prepare to add a use counter for Intl.v8BreakIterator BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183067

Patch Set 1 #

Total comments: 2

Patch Set 2 : Break in switch case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Source/bindings/core/v8/V8PerIsolateData.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Erik Corry
Preparation for landing https://codereview.chromium.org/619913002
6 years, 2 months ago (2014-10-01 13:39:55 UTC) #2
Mike West
LGTM. https://codereview.chromium.org/621593003/diff/1/Source/bindings/core/v8/V8PerIsolateData.cpp File Source/bindings/core/v8/V8PerIsolateData.cpp (right): https://codereview.chromium.org/621593003/diff/1/Source/bindings/core/v8/V8PerIsolateData.cpp#newcode62 Source/bindings/core/v8/V8PerIsolateData.cpp:62: // UseCounter::BreakIterator. Nit: Can you explicitly return here? ...
6 years, 2 months ago (2014-10-01 13:41:54 UTC) #4
Erik Corry
https://codereview.chromium.org/621593003/diff/1/Source/bindings/core/v8/V8PerIsolateData.cpp File Source/bindings/core/v8/V8PerIsolateData.cpp (right): https://codereview.chromium.org/621593003/diff/1/Source/bindings/core/v8/V8PerIsolateData.cpp#newcode62 Source/bindings/core/v8/V8PerIsolateData.cpp:62: // UseCounter::BreakIterator. On 2014/10/01 13:41:54, Mike West wrote: > ...
6 years, 2 months ago (2014-10-01 13:43:57 UTC) #5
Mike West
On 2014/10/01 13:43:57, Erik Corry wrote: > https://codereview.chromium.org/621593003/diff/1/Source/bindings/core/v8/V8PerIsolateData.cpp > File Source/bindings/core/v8/V8PerIsolateData.cpp (right): > > https://codereview.chromium.org/621593003/diff/1/Source/bindings/core/v8/V8PerIsolateData.cpp#newcode62 ...
6 years, 2 months ago (2014-10-01 13:46:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/621593003/20001
6 years, 2 months ago (2014-10-01 14:03:17 UTC) #8
haraken
LGTM
6 years, 2 months ago (2014-10-01 14:30:22 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 15:29:05 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 183067

Powered by Google App Engine
This is Rietveld 408576698