Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 619913002: Add a use counter for Intl.v8BreakIterator (Closed)

Created:
6 years, 2 months ago by Erik Corry Chromium.org
Modified:
6 years, 2 months ago
Reviewers:
Erik Corry, marja
CC:
v8-dev, Paweł Hajdan Jr.
Project:
v8
Visibility:
Public.

Description

Add a use counter for Intl.v8BreakIterator R=marja@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M include/v8.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/i18n.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Erik Corry Chromium.org
6 years, 2 months ago (2014-10-01 13:37:42 UTC) #1
marja
6 years, 2 months ago (2014-10-02 06:48:34 UTC) #2
marja
lgtm
6 years, 2 months ago (2014-10-02 06:49:25 UTC) #3
jochen (gone - plz use gerrit)
do you have a pointer to the blink side CL?
6 years, 2 months ago (2014-10-02 06:49:58 UTC) #4
marja
Humm, this one I saw was only a preparation CL and doesn't tie all the ...
6 years, 2 months ago (2014-10-02 06:56:49 UTC) #5
Erik Corry
I haven't written the final version of the Blink change. I think it can't be ...
6 years, 2 months ago (2014-10-02 14:45:59 UTC) #7
Erik Corry Chromium.org
6 years, 2 months ago (2014-10-03 10:29:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24400 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698