Issue 62167: Distributor logo and " - App Name" shouldn't be shown on app frame windows....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 62167: Distributor logo and " - App Name" shouldn't be shown on app frame windows.... (Closed)

Created:
11 years, 8 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Distributor logo and " - App Name" shouldn't be shown on app frame windows. http://crbug.com/6138 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13393

Patch Set 2 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -5 lines)			Patch
M	chrome/app/chromium_strings.grd	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/app/google_chrome_strings.grd	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/browser.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/browser.cc	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/views/frame/browser_view.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/views/frame/glass_browser_frame_view.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/views/frame/opaque_browser_frame_view.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

Need to patch/include glass_browser_frame_view.cc as well. LGTM otherwise. http://codereview.chromium.org/62167/diff/1/4 File chrome/browser/browser.cc (right): http://codereview.chromium.org/62167/diff/1/4#newcode422 Line 422: ...

11 years, 8 months ago (2009-04-08 23:01:26 UTC) #2

updated to include other file

Expand Messages | Collapse Messages

Issue 62167: Distributor logo and " - App Name" shouldn't be shown on app frame windows.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages