Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: chrome/browser/browser.cc

Issue 62167: Distributor logo and " - App Name" shouldn't be shown on app frame windows.... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser.h ('k') | chrome/browser/views/frame/browser_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser.cc
===================================================================
--- chrome/browser/browser.cc (revision 13385)
+++ chrome/browser/browser.cc (working copy)
@@ -414,7 +414,12 @@
if (title.empty())
title = l10n_util::GetString(IDS_TAB_UNTITLED_TITLE);
- return l10n_util::GetStringF(IDS_BROWSER_WINDOW_TITLE_FORMAT, title);
+ int string_id = IDS_BROWSER_WINDOW_TITLE_FORMAT;
+ // Don't append the app name to window titles when we're not displaying a
+ // distributor logo for the frame.
+ if (!ShouldShowDistributorLogo())
+ string_id = IDS_BROWSER_WINDOW_TITLE_FORMAT_NO_LOGO;
+ return l10n_util::GetStringF(string_id, title);
}
// static
@@ -428,6 +433,10 @@
}
}
+bool Browser::ShouldShowDistributorLogo() const {
+ // Don't show the distributor logo on app frames and app popups.
+ return !(type_ & TYPE_APP);
+}
///////////////////////////////////////////////////////////////////////////////
// Browser, OnBeforeUnload handling:
« no previous file with comments | « chrome/browser/browser.h ('k') | chrome/browser/views/frame/browser_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698