Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 621263003: Move version branding to before relocation packing. (Closed)

Created:
6 years, 2 months ago by simonb (inactive)
Modified:
6 years, 2 months ago
Reviewers:
Feng Qian, rmcilroy
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move version branding to before relocation packing. Objcopy knows nothing about the dynamic tags that point to packed relocation data. If objcopy is run after relocation packing, and if it moves the .android.rel.dyn section, these dynamic tags become invalid and the crazy linker cannot load the library: E/chromium_android_linker( 9584): Open: Could not open libchrome.2180.0.so: Bad packed relocations ident, expected APR1 or APA1 Currently, version branding happens at the end of building libchrome.so, and after relocation packing. Re-order so that relocation packing again comes after all other strip and/or objcopy operations. BUG=417510 Committed: https://crrev.com/4749549c06525071692f777fc6a1fa5a9ad7f877 Cr-Commit-Position: refs/heads/master@{#298236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M build/android/gyp/insert_chromium_version.py View 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/insert_chromium_version.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M build/java_apk.gypi View 4 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
simonb (inactive)
6 years, 2 months ago (2014-10-06 13:10:40 UTC) #2
rmcilroy
On 2014/10/06 13:10:40, simonb wrote: lgtm, thanks.
6 years, 2 months ago (2014-10-06 13:18:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/621263003/1
6 years, 2 months ago (2014-10-06 13:35:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1603a43b770c8a352d826c3e9203fb2b89a3e145
6 years, 2 months ago (2014-10-06 14:36:08 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 14:36:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4749549c06525071692f777fc6a1fa5a9ad7f877
Cr-Commit-Position: refs/heads/master@{#298236}

Powered by Google App Engine
This is Rietveld 408576698