build/android/insert_chromium_version.gypi - Issue 621263003: Move version branding to before relocation packing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/insert_chromium_version.gypi

Issue 621263003: Move version branding to before relocation packing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/insert_chromium_version.gypi

diff --git a/build/android/insert_chromium_version.gypi b/build/android/insert_chromium_version.gypi

index 158a2279177bb220341b2d5b618d185a3dc08662..a6ff9081086c711c0b8563a330eeb5f471c8da62 100644

--- a/build/android/insert_chromium_version.gypi

+++ b/build/android/insert_chromium_version.gypi

@@ -11,7 +11,7 @@

# 'actions': [

# 'variables': {

# 'ordered_libraries_file': 'file generated by write_ordered_libraries'

-# 'libraries_source_dir': 'the directory contains native libraries'

+# 'stripped_libraries_dir': 'the directory contains native libraries'

# 'input_paths': 'files to be added to the list of inputs'

# 'stamp': 'file to touch when the action is complete'

# 'version_string': 'chromium version string to be inserted'

@@ -37,7 +37,7 @@

'action': [

'python', '<(DEPTH)/build/android/gyp/insert_chromium_version.py',

'--android-objcopy=<(android_objcopy)',

- '--libraries-source-dir=<(libraries_source_dir)',

+ '--stripped-libraries-dir=<(stripped_libraries_dir)',

'--libraries=@FileArg(<(ordered_libraries_file):libraries)',

'--version-string=<(version_string)',

'--stamp=<(stamp)',

« no previous file with comments | « build/android/gyp/insert_chromium_version.py ('k') | build/java_apk.gypi » ('j') | no next file with comments »