build/android/gyp/insert_chromium_version.py - Issue 621263003: Move version branding to before relocation packing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/insert_chromium_version.py

Issue 621263003: Move version branding to before relocation packing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/gyp/insert_chromium_version.py

diff --git a/build/android/gyp/insert_chromium_version.py b/build/android/gyp/insert_chromium_version.py

index f858225612576f588b2d8c5915ef881bc922796a..171f9d41b8d1d70f281b6c5fb6a65c2d347e25fb 100755

--- a/build/android/gyp/insert_chromium_version.py

+++ b/build/android/gyp/insert_chromium_version.py

@@ -38,7 +38,7 @@ def main(args):

parser.add_option('--android-objcopy',

help='Path to the toolchain\'s objcopy binary')

- parser.add_option('--libraries-source-dir',

+ parser.add_option('--stripped-libraries-dir',

help='Directory of native libraries')

parser.add_option('--libraries',

help='List of libraries')

@@ -50,7 +50,7 @@ def main(args):

libraries = build_utils.ParseGypList(options.libraries)

for library in libraries:

- library_path = os.path.join(options.libraries_source_dir, library)

+ library_path = os.path.join(options.stripped_libraries_dir, library)

InsertChromiumVersion(options.android_objcopy,

library_path,

« no previous file with comments | « no previous file | build/android/insert_chromium_version.gypi » ('j') | no next file with comments »