Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 620953003: DevTools: Use resource name to detect toolbox web contents resource (Closed)

Created:
6 years, 2 months ago by apavlov
Modified:
6 years, 2 months ago
Reviewers:
vsevik, dgozman, yurys
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

DevTools: Use resource name to detect toolbox web contents resource This is the Chromium part of a two-sided patch. The Blink part is https://codereview.chromium.org/615893004 R=dgozman, vsevik Committed: https://crrev.com/2ffa5f6b52416fe1684ec64b36b876641f3a9d6b Cr-Commit-Position: refs/heads/master@{#297806}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/devtools/devtools_window.cc View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 8 (2 generated)
apavlov
6 years, 2 months ago (2014-10-02 10:01:28 UTC) #1
dgozman
lgtm https://codereview.chromium.org/620953003/diff/1/chrome/browser/devtools/devtools_window.cc File chrome/browser/devtools/devtools_window.cc (right): https://codereview.chromium.org/620953003/diff/1/chrome/browser/devtools/devtools_window.cc#newcode864 chrome/browser/devtools/devtools_window.cc:864: target_url.path().rfind("toolbox.html") != std::string::npos) { There is no difference ...
6 years, 2 months ago (2014-10-02 10:08:10 UTC) #2
apavlov
https://codereview.chromium.org/620953003/diff/1/chrome/browser/devtools/devtools_window.cc File chrome/browser/devtools/devtools_window.cc (right): https://codereview.chromium.org/620953003/diff/1/chrome/browser/devtools/devtools_window.cc#newcode864 chrome/browser/devtools/devtools_window.cc:864: target_url.path().rfind("toolbox.html") != std::string::npos) { On 2014/10/02 10:08:10, dgozman wrote: ...
6 years, 2 months ago (2014-10-02 10:10:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620953003/1
6 years, 2 months ago (2014-10-02 10:15:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 704fa2f3912e329ee4b34d0e74fcbae8023348ca
6 years, 2 months ago (2014-10-02 11:36:49 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 11:37:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ffa5f6b52416fe1684ec64b36b876641f3a9d6b
Cr-Commit-Position: refs/heads/master@{#297806}

Powered by Google App Engine
This is Rietveld 408576698