Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 615893004: DevTools: Use "toolbox.html" in URL passed to window.open() as a toolbox (Closed)

Created:
6 years, 2 months ago by apavlov
Modified:
6 years, 2 months ago
Reviewers:
vsevik, dgozman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Use "toolbox.html" in URL passed to window.open() as a toolbox This is the Blink part of a two-sided change. The Chromium part is https://codereview.chromium.org/620953003 R=dgozman, vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M Source/devtools/front_end/main/AdvancedApp.js View 1 chunk +1 line, -5 lines 0 comments Download
M Source/devtools/front_end/toolbox_bootstrap/Toolbox.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
apavlov
6 years, 2 months ago (2014-10-02 10:03:43 UTC) #1
dgozman
It just came to my mind that we should strip unnecessary query params when opening ...
6 years, 2 months ago (2014-10-02 10:12:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615893004/1
6 years, 2 months ago (2014-10-02 11:45:54 UTC) #4
apavlov
On 2014/10/02 10:12:41, dgozman wrote: > It just came to my mind that we should ...
6 years, 2 months ago (2014-10-02 11:55:23 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 12:48:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183133

Powered by Google App Engine
This is Rietveld 408576698