chrome/browser/devtools/devtools_window.cc - Issue 620953003: DevTools: Use resource name to detect toolbox web contents resource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 620953003: DevTools: Use resource name to detect toolbox web contents resource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/devtools_window.cc

diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc

index 072b1e82c61168a7f94e4aa582d9d9afeab73c2f..3a5db207cd1491f46d04af83bb0e6fabef49f75a 100644

--- a/chrome/browser/devtools/devtools_window.cc

+++ b/chrome/browser/devtools/devtools_window.cc

@@ -861,7 +861,7 @@ void DevToolsWindow::WebContentsCreated(WebContents* source_contents,

const GURL& target_url,

WebContents* new_contents) {

if (target_url.SchemeIs(content::kChromeDevToolsScheme) &&

- target_url.query().find("toolbox=true") != std::string::npos) {

+ target_url.path().rfind("toolbox.html") != std::string::npos) {

dgozman 2014/10/02 10:08:10 There is no difference between find and rfind here

apavlov 2014/10/02 10:10:23 We know that it will be A TAD faster :)

CHECK(can_dock_);

toolbox_web_contents_ = new_contents;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »