Issue 620683006: Move PlatformEventDispatcher implementations to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 620683006: Move PlatformEventDispatcher implementations to the Oilpan heap. (Closed)

Created:
6 years, 2 months ago by sof

Modified:
6 years, 2 months ago

Reviewers:

CC:
blink-reviews, mvanouwerkerk+watch_chromium.org, Inactive, timvolodine

Base URL:
https://chromium.googlesource.com/chromium/blink.git@sof-fix-platform

Project:
blink

Visibility:
Public.

More Reviews

Description

Move PlatformEventDispatcher implementations to the Oilpan heap. Make PlatformEventDispatcher a GC mixin, maintaining weak references to its registered controllers. R= BUG=340522

Patch Set 1 #

Patch Set 2 : Rebased onto master (r183158) #

Patch Set 3 : Set baseurl #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -52 lines)			Patch
M	Source/core/frame/PlatformEventDispatcher.h	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	Source/core/frame/PlatformEventDispatcher.cpp	View	2 chunks	+17 lines, -4 lines	0 comments	Download
M	Source/modules/battery/BatteryDispatcher.h	View	2 chunks	+8 lines, -5 lines	0 comments	Download
M	Source/modules/battery/BatteryDispatcher.cpp	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	Source/modules/device_light/DeviceLightDispatcher.h	View	2 chunks	+9 lines, -5 lines	0 comments	Download
M	Source/modules/device_light/DeviceLightDispatcher.cpp	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	Source/modules/device_orientation/DeviceMotionDispatcher.h	View	1 chunk	+9 lines, -6 lines	0 comments	Download
M	Source/modules/device_orientation/DeviceMotionDispatcher.cpp	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	Source/modules/device_orientation/DeviceOrientationDispatcher.h	View	1 chunk	+9 lines, -6 lines	0 comments	Download
M	Source/modules/device_orientation/DeviceOrientationDispatcher.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/modules/gamepad/GamepadDispatcher.h	View	2 chunks	+9 lines, -6 lines	0 comments	Download
M	Source/modules/gamepad/GamepadDispatcher.cpp	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	Source/modules/screen_orientation/ScreenOrientationDispatcher.h	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	Source/modules/screen_orientation/ScreenOrientationDispatcher.cpp	View	1 chunk	+4 lines, -3 lines	0 comments	Download