ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread.

chrome/browser/ui/webui/chromeos/login/network_screen_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_CHROMEOS_LOGIN_NETWORK_SCREEN_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_CHROMEOS_LOGIN_NETWORK_SCREEN_HANDLER_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
@@ skipping 41 matching lines @@
   virtual void RegisterMessages() OVERRIDE;
 
   // InputMethodManager::Observer implementation:
   virtual void InputMethodChanged(input_method::InputMethodManager* manager,
                                   bool show_message) OVERRIDE;
 
   // Reloads localized contents.
   void ReloadLocalizedContent();
 
  private:
+  struct LanguageSwitchResult {
+    std::string requested_locale;
+    std::string loaded_locale;
+    bool success;
+  };
+
   // Handles moving off the screen.
   void HandleOnExit();
 
   // Handles change of the language.
   void HandleOnLanguageChanged(const std::string& locale);
 
   // Async callback after ReloadResourceBundle(locale) completed.
   static void OnLanguageChangedCallback(
       scoped_ptr<NetworkScreenHandlerOnLanguageChangedCallbackData> context,
       const std::string& requested_locale,
       const std::string& loaded_locale,
       const bool success);
 
   // Handles change of the input method.
   void HandleOnInputMethodChanged(const std::string& id);
 
   // Handles change of the time zone
   void HandleOnTimezoneChanged(const std::string& timezone);
 
   // Callback when the system timezone settings is changed.
   void OnSystemTimezoneChanged();
 
   // Returns available timezones. Caller gets the ownership.
   static base::ListValue* GetTimezoneList();
 
+  // Starts resolving language list on BlockingPool.
+  void ScheduleResolveLanguageList();
+
+  // Callback for ScheduleResolveLanguageList().
+  void OnLanguageListResolved(
+      scoped_ptr<scoped_ptr<base::ListValue>> new_language_list,
+      scoped_ptr<std::string> new_language_list_locale,
+      scoped_ptr<std::string> new_selected_language);
+
   NetworkScreenActor::Delegate* screen_;
   CoreOobeActor* core_oobe_actor_;
 
   bool is_continue_enabled_;
 
   // Keeps whether screen should be shown right after initialization.
   bool show_on_init_;
 
   // Position of the network control.
   gfx::Point network_control_pos_;
 
   scoped_ptr<CrosSettings::ObserverSubscription> timezone_subscription_;
 
   // The exact language code selected by user in the menu.
   std::string selected_language_code_;
 
+  // Creation of language list happens on Blocking Pool, so we cache resolved
+  // data.
+  std::string language_list_locale_;
+  scoped_ptr<base::ListValue> language_list_;
+
+  // "Selected language" should be calculated on Blocking Pool, so we need to
+  // remember results of language switching.
+  LanguageSwitchResult language_switch_result_;

[dzhioev (left Google), 2014/10/01 15:08:08]

No need to save this struct.

[Alexander Alekseev, 2014/10/02 13:12:07]

Done.

+
   base::WeakPtrFactory<NetworkScreenHandler> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkScreenHandler);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_UI_WEBUI_CHROMEOS_LOGIN_NETWORK_SCREEN_HANDLER_H_