ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread.

chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/chromeos/login/network_screen_handler.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/memory/weak_ptr.h"
 #include "base/prefs/pref_service.h"
+#include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/task_runner_util.h"
+#include "base/threading/worker_pool.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/accessibility/accessibility_manager.h"
 #include "chrome/browser/chromeos/base/locale_util.h"
 #include "chrome/browser/chromeos/customization_document.h"
 #include "chrome/browser/chromeos/idle_detector.h"
 #include "chrome/browser/chromeos/login/screens/core_oobe_actor.h"
 #include "chrome/browser/chromeos/login/ui/input_events_blocker.h"
 #include "chrome/browser/chromeos/system/input_device_settings.h"
 #include "chrome/browser/chromeos/system/timezone_util.h"
 #include "chrome/browser/ui/webui/chromeos/login/l10n_util.h"
 #include "chrome/browser/ui/webui/chromeos/login/oobe_ui.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/grit/generated_resources.h"
 #include "chromeos/ime/extension_ime_util.h"
 #include "chromeos/network/network_handler.h"
 #include "chromeos/network/network_state_handler.h"
+#include "content/public/browser/browser_thread.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/rect.h"
 #include "ui/views/layout/fill_layout.h"
 #include "ui/views/widget/widget.h"
 
 namespace {
 
 const char kJsScreenPath[] = "login.NetworkScreen";
 
 // JS API callbacks names.
 const char kJsApiNetworkOnExit[] = "networkOnExit";
 const char kJsApiNetworkOnLanguageChanged[] = "networkOnLanguageChanged";
 const char kJsApiNetworkOnInputMethodChanged[] = "networkOnInputMethodChanged";
 const char kJsApiNetworkOnTimezoneChanged[] = "networkOnTimezoneChanged";
 
-// For "UI Language" drop-down menu at OOBE screen we need to decide which
-// entry to mark "selected". If user has just selected "requested_locale",
-// but "loaded_locale" was actually loaded, we mark original user choice
-// "selected" only if loaded_locale is a backup for "requested_locale".
-std::string CalculateSelectedLanguage(const std::string& requested_locale,
-                                      const std::string& loaded_locale) {
-  std::string resolved_locale;
-  if (!l10n_util::CheckAndResolveLocale(requested_locale, &resolved_locale))
-    return loaded_locale;
-
-  if (resolved_locale == loaded_locale)
-    return requested_locale;
-
-  return loaded_locale;
-}
-
 }  // namespace
 
 namespace chromeos {
 
 // NetworkScreenHandler, public: -----------------------------------------------
 
 NetworkScreenHandler::NetworkScreenHandler(CoreOobeActor* core_oobe_actor)
     : BaseScreenHandler(kJsScreenPath),
       screen_(NULL),
       core_oobe_actor_(core_oobe_actor),
@@ skipping 93 matching lines @@
   builder->Add("networkScreenAccessibleTitle",
                IDS_NETWORK_SCREEN_ACCESSIBLE_TITLE);
   builder->Add("selectLanguage", IDS_LANGUAGE_SELECTION_SELECT);
   builder->Add("selectKeyboard", IDS_KEYBOARD_SELECTION_SELECT);
   builder->Add("selectNetwork", IDS_NETWORK_SELECTION_SELECT);
   builder->Add("selectTimezone", IDS_OPTIONS_SETTINGS_TIMEZONE_DESCRIPTION);
   builder->Add("proxySettings", IDS_OPTIONS_PROXIES_CONFIGURE_BUTTON);
   builder->Add("continueButton", IDS_NETWORK_SELECTION_CONTINUE_BUTTON);
 }
 
+void NetworkScreenHandler::OnLanguageListResolved(
+    scoped_ptr<base::ListValue> new_language_list,
+    std::string new_language_list_locale,
+    std::string new_selected_language) {
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+
+  language_list_.reset(new_language_list.release());
+  language_list_locale_ = new_language_list_locale;
+  selected_language_code_ = new_selected_language;
+
+  g_browser_process->local_state()->SetString(prefs::kApplicationLocale,
+                                              selected_language_code_);
+  ReloadLocalizedContent();
+}
+
+void NetworkScreenHandler::ScheduleResolveLanguageList(
+    scoped_ptr<locale_util::LanguageSwitchResult> language_switch_result) {
+  UILanguageListResolvedCallback callback =
+      base::Bind(&NetworkScreenHandler::OnLanguageListResolved,
+                 weak_ptr_factory_.GetWeakPtr());
+  ResolveUILanguageList(language_switch_result.Pass(), callback);
+}
+
 void NetworkScreenHandler::GetAdditionalParameters(
     base::DictionaryValue* dict) {
   const std::string application_locale =
       g_browser_process->GetApplicationLocale();
-  const std::string selected_language = selected_language_code_.empty() ?
-      application_locale : selected_language_code_;
   const std::string selected_input_method =
       input_method::InputMethodManager::Get()
           ->GetActiveIMEState()
           ->GetCurrentInputMethod()
           .id();
 
-  dict->Set("languageList",
-            GetUILanguageList(NULL, selected_language).release());
+  scoped_ptr<base::ListValue> language_list;
+  if (language_list_.get() && language_list_locale_ == application_locale) {
+    language_list.reset(language_list_->DeepCopy());
+  } else {
+    ScheduleResolveLanguageList(
+        scoped_ptr<locale_util::LanguageSwitchResult>());
+
+    language_list.reset(GetMinimalUILanguageList().release());
+  }
+
+  dict->Set("languageList", language_list.release());
   dict->Set("inputMethodsList",
             GetAndActivateLoginKeyboardLayouts(
                 application_locale, selected_input_method).release());
   dict->Set("timezoneList", GetTimezoneList());
 }
 
 void NetworkScreenHandler::Initialize() {
   EnableContinue(is_continue_enabled_);
   if (show_on_init_) {
     show_on_init_ = false;
@@ skipping 22 matching lines @@
 
 // NetworkScreenHandler, private: ----------------------------------------------
 
 void NetworkScreenHandler::HandleOnExit() {
   core_oobe_actor_->StopDemoModeDetection();
   ClearErrors();
   if (screen_)
     screen_->OnContinuePressed();
 }
 
-struct NetworkScreenHandlerOnLanguageChangedCallbackData {
-  explicit NetworkScreenHandlerOnLanguageChangedCallbackData(
-      const base::WeakPtr<NetworkScreenHandler>& handler)
-      : handler(handler) {}
-
-  base::WeakPtr<NetworkScreenHandler> handler;
-
-  // Block UI while resource bundle is being reloaded.
-  chromeos::InputEventsBlocker input_events_blocker;
-};
-
-// static
 void NetworkScreenHandler::OnLanguageChangedCallback(
-    scoped_ptr<NetworkScreenHandlerOnLanguageChangedCallbackData> context,
-    const std::string& requested_locale,
-    const std::string& loaded_locale,
-    const bool success) {
-  if (!context || !context->handler)
-    return;
-
-  NetworkScreenHandler* const self = context->handler.get();
-
-  if (success) {
-    if (requested_locale == loaded_locale) {
-      self->selected_language_code_ = requested_locale;
-    } else {
-      self->selected_language_code_ =
-          CalculateSelectedLanguage(requested_locale, loaded_locale);
-    }
-  } else {
-    self->selected_language_code_ = loaded_locale;
+    const chromeos::InputEventsBlocker* /* input_events_blocker */,
+    const locale_util::LanguageSwitchResult& result) {
+  if (!selected_language_code_.empty()) {
+    // We still do not have device owner, so owner settings are not applied.
+    // But Guest session can be started before owner is created, so we need to
+    // save locale settings directly here.
+    g_browser_process->local_state()->SetString(prefs::kApplicationLocale,
+                                                selected_language_code_);
   }
-
-  self->ReloadLocalizedContent();
-
-  // We still do not have device owner, so owner settings are not applied.
-  // But Guest session can be started before owner is created, so we need to
-  // save locale settings directly here.
-  g_browser_process->local_state()->SetString(prefs::kApplicationLocale,
-                                              self->selected_language_code_);
+  ScheduleResolveLanguageList(
+      scoped_ptr<locale_util::LanguageSwitchResult>(
+          new locale_util::LanguageSwitchResult(result)).Pass());

[dzhioev (left Google), 2014/10/02 20:14:29]

nit: Is 'Pass' needed here?

[Alexander Alekseev, 2014/10/02 21:06:52]

Done.

 
   AccessibilityManager::Get()->OnLocaleChanged();
 }
 
 void NetworkScreenHandler::HandleOnLanguageChanged(const std::string& locale) {
   const std::string app_locale = g_browser_process->GetApplicationLocale();
   if (app_locale == locale)
     return;
 
-  base::WeakPtr<NetworkScreenHandler> weak_self =
-      weak_ptr_factory_.GetWeakPtr();
-  scoped_ptr<NetworkScreenHandlerOnLanguageChangedCallbackData> callback_data(
-      new NetworkScreenHandlerOnLanguageChangedCallbackData(weak_self));
-  scoped_ptr<locale_util::SwitchLanguageCallback> callback(
-      new locale_util::SwitchLanguageCallback(
-          base::Bind(&NetworkScreenHandler::OnLanguageChangedCallback,
-                     base::Passed(callback_data.Pass()))));
+  // Block UI while resource bundle is being reloaded.
+  // (InputEventsBlocker will live until callback is finished.)
+  locale_util::SwitchLanguageCallback callback(
+      base::Bind(&NetworkScreenHandler::OnLanguageChangedCallback,
+                 weak_ptr_factory_.GetWeakPtr(),
+                 base::Owned(new chromeos::InputEventsBlocker)));
   locale_util::SwitchLanguage(locale,
                               true /* enableLocaleKeyboardLayouts */,
                               true /* login_layouts_only */,
-                              callback.Pass());
+                              callback);
 }
 
 void NetworkScreenHandler::HandleOnInputMethodChanged(const std::string& id) {
   input_method::InputMethodManager::Get()
       ->GetActiveIMEState()
       ->ChangeInputMethod(id, false /* show_message */);
 }
 
 void NetworkScreenHandler::HandleOnTimezoneChanged(
     const std::string& timezone_id) {
@@ skipping 49 matching lines @@
     timezone_option->SetString("value", timezone_id);
     timezone_option->SetString("title", timezone_name);
     timezone_option->SetBoolean("selected", timezone_id == current_timezone_id);
     timezone_list->Append(timezone_option.release());
   }
 
   return timezone_list.release();
 }
 
 }  // namespace chromeos