Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 620483002: Drop FilterDataState::Applying (Closed)

Created:
6 years, 2 months ago by fs
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, ed+blinkwatch_opera.com, krit, gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink
Project:
blink
Visibility:
Public.

Description

Drop FilterDataState::Applying This state is never transitioned to, so it can be removed. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M Source/core/rendering/svg/RenderSVGResourceFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.cpp View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
fs
Probably something that should've been in https://codereview.chromium.org/500233002. (Discovered while trying to figure out what transitions ...
6 years, 2 months ago (2014-09-30 16:06:12 UTC) #2
f(malita)
lgtm
6 years, 2 months ago (2014-09-30 16:08:26 UTC) #3
Stephen White
LGTM too. Thanks for this!
6 years, 2 months ago (2014-09-30 16:09:01 UTC) #4
Stephen Chennney
Did I add this to fix a security problem? I seem to recall things going ...
6 years, 2 months ago (2014-09-30 16:13:31 UTC) #5
f(malita)
On 2014/09/30 16:13:31, Stephen Chenney wrote: > Did I add this to fix a security ...
6 years, 2 months ago (2014-09-30 16:22:08 UTC) #6
fs
On 2014/09/30 16:22:08, Florin Malita wrote: > On 2014/09/30 16:13:31, Stephen Chenney wrote: > > ...
6 years, 2 months ago (2014-09-30 16:26:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620483002/1
6 years, 2 months ago (2014-09-30 16:26:59 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 17:32:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182947

Powered by Google App Engine
This is Rietveld 408576698