Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 500233002: First pass at ripping out non-deferred SVG filter path. (Closed)

Created:
6 years, 4 months ago by Stephen White
Modified:
6 years, 3 months ago
Reviewers:
f(malita)
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink
Project:
blink
Visibility:
Public.

Description

First pass at ripping out non-deferred SVG filter path. There will be more to come, especially once the CSS deferred path has proven itself and stuck and we can remove big chunks of FilterEffect. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182529

Patch Set 1 #

Patch Set 2 : Update to ToT #

Patch Set 3 : Remove "MarkedForRemoval" state from SVG filter state machine (now unused) #

Patch Set 4 : Update to ToT #

Total comments: 3

Patch Set 5 : Fix re: review comments #

Patch Set 6 : Nuke more code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -174 lines) Patch
M Source/core/rendering/svg/RenderSVGResourceFilter.h View 1 2 3 2 chunks +2 lines, -9 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.cpp View 1 2 3 4 5 7 chunks +8 lines, -158 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/graphics/filters/SVGFilter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFilter.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Stephen White
Florin: PTAL. (This is largely a negative delta.) Thanks!
6 years, 3 months ago (2014-09-23 17:43:59 UTC) #2
f(malita)
This is so awesome! LGTM https://codereview.chromium.org/500233002/diff/60001/Source/core/rendering/svg/RenderSVGResourceFilter.cpp File Source/core/rendering/svg/RenderSVGResourceFilter.cpp (left): https://codereview.chromium.org/500233002/diff/60001/Source/core/rendering/svg/RenderSVGResourceFilter.cpp#oldcode74 Source/core/rendering/svg/RenderSVGResourceFilter.cpp:74: filterData->state = FilterData::MarkedForRemoval; I ...
6 years, 3 months ago (2014-09-23 21:54:54 UTC) #3
Stephen White
Thanks for your review. https://codereview.chromium.org/500233002/diff/60001/Source/core/rendering/svg/RenderSVGResourceFilter.cpp File Source/core/rendering/svg/RenderSVGResourceFilter.cpp (right): https://codereview.chromium.org/500233002/diff/60001/Source/core/rendering/svg/RenderSVGResourceFilter.cpp#newcode73 Source/core/rendering/svg/RenderSVGResourceFilter.cpp:73: m_filter.remove(client); On 2014/09/23 21:54:54, Florin ...
6 years, 3 months ago (2014-09-23 22:01:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/500233002/80001
6 years, 3 months ago (2014-09-23 22:03:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/500233002/80001
6 years, 3 months ago (2014-09-23 22:03:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/500233002/100001
6 years, 3 months ago (2014-09-23 22:51:13 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 00:13:35 UTC) #11
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as 182529

Powered by Google App Engine
This is Rietveld 408576698