Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 620343002: DevTools: Remove geolocation override from renderer (Closed)

Created:
6 years, 2 months ago by vkuzkokov
Modified:
6 years, 2 months ago
CC:
blink-reviews, mvanouwerkerk+watch_chromium.org, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, timvolodine, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: Remove geolocation override from renderer Geolocation overrides moves from renderer to browser side. BUG=404995 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183688

Patch Set 1 #

Patch Set 2 : Expanded method description #

Patch Set 3 : Make geolocation tests work #

Patch Set 4 : Fixed test #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -283 lines) Patch
M LayoutTests/inspector/geolocation-emulation-tests.html View 1 2 3 4 3 chunks +31 lines, -31 lines 0 comments Download
D LayoutTests/inspector/geolocation-emulation-tests-expected.txt View 1 2 3 4 1 chunk +8 lines, -9 lines 0 comments Download
M Source/devtools/front_end/sdk/OverridesSupport.js View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/protocol.json View 1 2 3 2 chunks +3 lines, -22 lines 0 comments Download
M Source/modules/geolocation/GeolocationController.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M Source/modules/geolocation/GeolocationController.cpp View 5 chunks +1 line, -26 lines 0 comments Download
D Source/modules/geolocation/GeolocationInspectorAgent.h View 1 2 1 chunk +0 lines, -76 lines 0 comments Download
D Source/modules/geolocation/GeolocationInspectorAgent.cpp View 1 chunk +0 lines, -112 lines 0 comments Download
M Source/modules/modules.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 23 (9 generated)
vkuzkokov
6 years, 2 months ago (2014-10-03 14:43:14 UTC) #2
dgozman
lgtm
6 years, 2 months ago (2014-10-06 11:14:09 UTC) #3
Michael van Ouwerkerk
lgtm for modules/geolocation - thanks!
6 years, 2 months ago (2014-10-06 13:08:16 UTC) #5
vkuzkokov
Pavel, ptal Source/devtools/protocol.json
6 years, 2 months ago (2014-10-06 13:32:28 UTC) #7
pfeldman
lgtm
6 years, 2 months ago (2014-10-07 08:10:51 UTC) #8
vkuzkokov
Expanded method description as per comment in 603323004.
6 years, 2 months ago (2014-10-07 08:44:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620343002/20001
6 years, 2 months ago (2014-10-09 12:46:31 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/28483)
6 years, 2 months ago (2014-10-09 13:50:53 UTC) #13
vkuzkokov
On 2014/10/09 13:50:53, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-10-09 15:57:43 UTC) #14
dgozman
On 2014/10/09 15:57:43, vkuzkokov wrote: > On 2014/10/09 13:50:53, I haz the power (commit-bot) wrote: ...
6 years, 2 months ago (2014-10-12 07:41:38 UTC) #15
vkuzkokov
On 2014/10/12 07:41:38, dgozman wrote: > On 2014/10/09 15:57:43, vkuzkokov wrote: > > On 2014/10/09 ...
6 years, 2 months ago (2014-10-14 13:02:59 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620343002/70001
6 years, 2 months ago (2014-10-14 13:04:36 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620343002/290001
6 years, 2 months ago (2014-10-14 16:54:34 UTC) #22
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 18:15:07 UTC) #23
Message was sent while issue was closed.
Committed patchset #5 (id:290001) as 183688

Powered by Google App Engine
This is Rietveld 408576698