Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: Source/devtools/front_end/sdk/OverridesSupport.js

Issue 620343002: DevTools: Remove geolocation override from renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/inspector/geolocation-emulation-tests-expected.txt ('k') | Source/devtools/protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/OverridesSupport.js
diff --git a/Source/devtools/front_end/sdk/OverridesSupport.js b/Source/devtools/front_end/sdk/OverridesSupport.js
index 6868018e6d2a7ba3c0cf037de34d630797437f5b..92e10b59ea80be4220558bf57a2917fb8505467c 100644
--- a/Source/devtools/front_end/sdk/OverridesSupport.js
+++ b/Source/devtools/front_end/sdk/OverridesSupport.js
@@ -178,7 +178,7 @@ WebInspector.OverridesSupport.GeolocationPosition.parseUserInput = function(lati
WebInspector.OverridesSupport.GeolocationPosition.clearGeolocationOverride = function()
{
- GeolocationAgent.clearGeolocationOverride();
+ PageAgent.clearGeolocationOverride();
}
/**
@@ -646,14 +646,14 @@ WebInspector.OverridesSupport.prototype = {
_geolocationPositionChanged: function()
{
if (!this.emulationEnabled() || !this.settings.overrideGeolocation.get()) {
- GeolocationAgent.clearGeolocationOverride();
+ PageAgent.clearGeolocationOverride();
return;
}
var geolocation = WebInspector.OverridesSupport.GeolocationPosition.parseSetting(this.settings.geolocationOverride.get());
if (geolocation.error)
- GeolocationAgent.setGeolocationOverride();
+ PageAgent.setGeolocationOverride();
else
- GeolocationAgent.setGeolocationOverride(geolocation.latitude, geolocation.longitude, 150);
+ PageAgent.setGeolocationOverride(geolocation.latitude, geolocation.longitude, 150);
},
_deviceOrientationChanged: function()
« no previous file with comments | « LayoutTests/inspector/geolocation-emulation-tests-expected.txt ('k') | Source/devtools/protocol.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698