Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1512)

Unified Diff: Source/devtools/protocol.json

Issue 620343002: DevTools: Remove geolocation override from renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/protocol.json
diff --git a/Source/devtools/protocol.json b/Source/devtools/protocol.json
index 1c012310c7857c770f7685c422da69fb0f5def6f..9531b6f9286ef21257bc92d004c904a65cda9a2b 100644
--- a/Source/devtools/protocol.json
+++ b/Source/devtools/protocol.json
@@ -447,18 +447,18 @@
},
{
"name": "setGeolocationOverride",
- "description": "Overrides the Geolocation Position or Error.",
+ "description": "Overrides the Geolocation Position or Error. Omitting any of the parameters emulates position unavailable.",
"parameters": [
{ "name": "latitude", "type": "number", "optional": true, "description": "Mock latitude"},
{ "name": "longitude", "type": "number", "optional": true, "description": "Mock longitude"},
{ "name": "accuracy", "type": "number", "optional": true, "description": "Mock accuracy"}
],
- "redirect": "Geolocation"
+ "handlers": ["browser"]
},
{
"name": "clearGeolocationOverride",
"description": "Clears the overriden Geolocation Position and Error.",
- "redirect": "Geolocation"
+ "handlers": ["browser"]
},
{
"name": "setDeviceOrientationOverride",
@@ -4284,25 +4284,6 @@
]
},
{
- "domain": "Geolocation",
- "hidden": true,
- "commands": [
- {
- "name": "setGeolocationOverride",
- "description": "Overrides the Geolocation Position or Error.",
- "parameters": [
- { "name": "latitude", "type": "number", "optional": true, "description": "Mock latitude"},
- { "name": "longitude", "type": "number", "optional": true, "description": "Mock longitude"},
- { "name": "accuracy", "type": "number", "optional": true, "description": "Mock accuracy"}
- ]
- },
- {
- "name": "clearGeolocationOverride",
- "description": "Clears the overriden Geolocation Position and Error."
- }
- ]
- },
- {
"domain": "DeviceOrientation",
"hidden": true,
"commands": [
« no previous file with comments | « Source/devtools/front_end/sdk/OverridesSupport.js ('k') | Source/modules/geolocation/GeolocationController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698