Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 619863002: Introduce flag --allocation-site-transitioning

Created:
6 years, 2 months ago by mvstanton
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Introduce flag --allocation-site-transitioning We use allocation sites to optimize elements-kind transitioning. For experimental purposes, it's useful to turn this on and off. R=hpayer@chromium.org

Patch Set 1 #

Patch Set 2 : REBASE. #

Patch Set 3 : Bugfix: nopretenure and notransition needed help. #

Patch Set 4 : Removed extra work happening when !transitioning && pretenuring. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -21 lines) Patch
M src/code-stubs.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/flag-definitions.h View 1 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 2 chunks +7 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 5 chunks +20 lines, -15 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/objects.cc View 1 3 chunks +7 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M src/runtime/runtime.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 9 chunks +9 lines, -0 lines 0 comments Download
M test/mjsunit/allocation-site-info.js View 1 chunk +4 lines, -0 lines 0 comments Download
M test/mjsunit/array-constructor-feedback.js View 1 chunk +4 lines, -0 lines 0 comments Download
M test/mjsunit/array-feedback.js View 1 chunk +4 lines, -0 lines 0 comments Download
M test/mjsunit/array-literal-feedback.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mvstanton
Hi Hannes, Not sure if we want to check this in or not, as it ...
6 years, 2 months ago (2014-10-01 11:02:05 UTC) #1
mvstanton
6 years, 2 months ago (2014-10-07 16:32:59 UTC) #2
Hi Hannes,
Here is the update we spoke of.

* Ran !transitioning && pretenuring -> tracing pretenuring stats had lots of
output in octane. Tracing transitioning stats (--trace-track-allocation-sites)
had ZERO output - as expected.
* Ran transitiong && !pretenuring -> not pretenuring stats output, but lots of
transitioning stats output - as expected.
thx,
--Michael

Powered by Google App Engine
This is Rietveld 408576698