Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: src/objects.cc

Issue 619863002: Introduce flag --allocation-site-transitioning Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Removed extra work happening when !transitioning && pretenuring. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index f6ec456bd4ddebf0349bf77a6b235aae48c3d784..0ef99f864ad0e400cde16a9b33d7642663639e5d 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -12596,6 +12596,7 @@ bool AllocationSite::IsNestedSite() {
void AllocationSite::DigestTransitionFeedback(Handle<AllocationSite> site,
ElementsKind to_kind) {
+ DCHECK(FLAG_allocation_site_transitioning);
Isolate* isolate = site->GetIsolate();
if (site->SitePointsToLiteral() && site->transition_info()->IsJSArray()) {
@@ -12651,6 +12652,11 @@ void AllocationSite::DigestTransitionFeedback(Handle<AllocationSite> site,
void AllocationSite::AddDependentCompilationInfo(Handle<AllocationSite> site,
Reason reason,
CompilationInfo* info) {
+ if ((!FLAG_allocation_site_pretenuring && reason == TENURING) ||
+ (!FLAG_allocation_site_transitioning && reason == TRANSITIONS)) {
+ return;
+ }
+
DependentCode::DependencyGroup group = site->ToDependencyGroup(reason);
Handle<DependentCode> dep(site->dependent_code());
Handle<DependentCode> codes =
@@ -12675,6 +12681,7 @@ const char* AllocationSite::PretenureDecisionName(PretenureDecision decision) {
void JSObject::UpdateAllocationSite(Handle<JSObject> object,
ElementsKind to_kind) {
+ if (!FLAG_allocation_site_transitioning) return;
if (!object->IsJSArray()) return;
Heap* heap = object->GetHeap();
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698