Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: src/objects-inl.h

Issue 619863002: Introduce flag --allocation-site-transitioning Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Removed extra work happening when !transitioning && pretenuring. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index 59efdf0a89269799f4b9bd5ddc8ef766f04b77e6..2de533a3eb22187a02453fe1fb3dfdb5b8705da9 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -1604,7 +1604,8 @@ void AllocationSite::MarkZombie() {
AllocationSiteMode AllocationSite::GetMode(
ElementsKind boilerplate_elements_kind) {
if (FLAG_pretenuring_call_new ||
- IsFastSmiElementsKind(boilerplate_elements_kind)) {
+ (FLAG_allocation_site_transitioning &&
+ IsFastSmiElementsKind(boilerplate_elements_kind))) {
return TRACK_ALLOCATION_SITE;
}
@@ -1615,7 +1616,7 @@ AllocationSiteMode AllocationSite::GetMode(
AllocationSiteMode AllocationSite::GetMode(ElementsKind from,
ElementsKind to) {
if (FLAG_pretenuring_call_new ||
- (IsFastSmiElementsKind(from) &&
+ (FLAG_allocation_site_transitioning && IsFastSmiElementsKind(from) &&
IsMoreGeneralElementsKindTransition(from, to))) {
return TRACK_ALLOCATION_SITE;
}
@@ -1630,7 +1631,7 @@ inline bool AllocationSite::CanTrack(InstanceType type) {
type == JS_OBJECT_TYPE ||
type < FIRST_NONSTRING_TYPE;
}
- return type == JS_ARRAY_TYPE;
+ return FLAG_allocation_site_transitioning && type == JS_ARRAY_TYPE;
}
« no previous file with comments | « src/objects.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698