Mojo: Convert OVERRIDE -> override in various subdirectories of mojo/.

Mojo: Convert OVERRIDE -> override in various subdirectories of mojo/.

(Every subdirectory except aura/, examples/, services/, and views/.)

R=jamesr@chromium.org

Committed: https://crrev.com/473e9133cbe6f90140bf172003e70ee788afc5d9
Cr-Commit-Position: refs/heads/master@{#297364}

[jamesr, 2014-09-30 04:58:56]

The CQ bit was checked by jamesr@chromium.org

[jamesr, 2014-09-30 04:58:56]

lgtm

[commit-bot: I haz the power, 2014-09-30 04:59:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/619493002/1

[commit-bot: I haz the power, 2014-09-30 05:05:01]

Committed patchset #1 (id:1) as c0ef0e0015390524549a932232800c0288ad746a

[commit-bot: I haz the power, 2014-09-30 05:05:37]

Patchset 1 (id:??) landed as
https://crrev.com/473e9133cbe6f90140bf172003e70ee788afc5d9
Cr-Commit-Position: refs/heads/master@{#297364}

[danakj, 2014-10-01 22:38:32]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2014-10-01 22:38:33]

https://codereview.chromium.org/619493002/diff/1/mojo/application_manager/app...
File mojo/application_manager/application_loader.h (right):

https://codereview.chromium.org/619493002/diff/1/mojo/application_manager/app...
mojo/application_manager/application_loader.h:50: virtual
ScopedMessagePipeHandle RegisterApplication() override;
wasn't the rule to not use "virtual" when using "override" because it's
redundant?

[viettrungluu, 2014-10-02 02:32:12]

On 2014/10/01 22:38:33, danakj wrote:
>
https://codereview.chromium.org/619493002/diff/1/mojo/application_manager/app...
> File mojo/application_manager/application_loader.h (right):
> 
>
https://codereview.chromium.org/619493002/diff/1/mojo/application_manager/app...
> mojo/application_manager/application_loader.h:50: virtual
> ScopedMessagePipeHandle RegisterApplication() override;
> wasn't the rule to not use "virtual" when using "override" because it's
> redundant?

I believe that it isn't a (practical) rule until someone updates the Chromium
style plugin.

(But since I don't believe it's able to tell the difference between "OVERRIDE"
and "override", the transition will be a little extra annoying.)

[jamesr, 2014-10-02 03:13:13]

That is currently not the rule.
On Oct 1, 2014 3:38 PM, <danakj@chromium.org> wrote:

>
> https://codereview.chromium.org/619493002/diff/1/mojo/application_manager/
> application_loader.h
> File mojo/application_manager/application_loader.h (right):
>
> https://codereview.chromium.org/619493002/diff/1/mojo/application_manager/
> application_loader.h#newcode50
> mojo/application_manager/application_loader.h:50: virtual
> ScopedMessagePipeHandle RegisterApplication() override;
> wasn't the rule to not use "virtual" when using "override" because it's
> redundant?
>
> https://codereview.chromium.org/619493002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2014-10-02 04:15:33]

Oh okay. I found this.
https://code.google.com/p/chromium/issues/detail?id=417463#c7. Sounds like
it'll be the rule soon then.
On Oct 1, 2014 11:13 PM, "James Robinson" <jamesr@chromium.org> wrote:

> That is currently not the rule.
> On Oct 1, 2014 3:38 PM, <danakj@chromium.org> wrote:
>
>>
>> https://codereview.chromium.org/619493002/diff/1/mojo/
>> application_manager/application_loader.h
>> File mojo/application_manager/application_loader.h (right):
>>
>> https://codereview.chromium.org/619493002/diff/1/mojo/
>> application_manager/application_loader.h#newcode50
>> mojo/application_manager/application_loader.h:50: virtual
>> ScopedMessagePipeHandle RegisterApplication() override;
>> wasn't the rule to not use "virtual" when using "override" because it's
>> redundant?
>>
>> https://codereview.chromium.org/619493002/
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.