Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 618513002: [DevTools] Address crash by checking if Tab loaded successfully (Closed)

Created:
6 years, 2 months ago by gone
Modified:
6 years, 2 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Address crash by checking if Tab loaded successfully * Changes Tab::LoadIfNeeded()/Tab.loadIfNeeded() to return true if the call was "handled" and false if it failed. * DevTools checks if LoadIfNeeded() fails, and bails out if it does. BUG=403592 Committed: https://crrev.com/b90614c44a566be2ed618df1e036cd441538c6ef Cr-Commit-Position: refs/heads/master@{#297482} R=dtrainor@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/251bb226ba998ce3b25f7a10116600d124c57a69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/dev_tools_manager_delegate_android.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
dgozman
I support this change.
6 years, 2 months ago (2014-09-30 11:55:05 UTC) #2
gone
6 years, 2 months ago (2014-09-30 18:08:58 UTC) #4
David Trainor- moved to gerrit
lgtm
6 years, 2 months ago (2014-09-30 18:34:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/618513002/1
6 years, 2 months ago (2014-09-30 18:37:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2ea66f5ad2f30dcad7ffa534c34d24f4e0058a34
6 years, 2 months ago (2014-09-30 19:34:26 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b90614c44a566be2ed618df1e036cd441538c6ef Cr-Commit-Position: refs/heads/master@{#297482}
6 years, 2 months ago (2014-09-30 19:35:04 UTC) #9
gone
6 years, 2 months ago (2014-10-03 17:45:34 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
251bb226ba998ce3b25f7a10116600d124c57a69 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698