Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 618513002: [DevTools] Address crash by checking if Tab loaded successfully (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/android/dev_tools_manager_delegate_android.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser; 5 package org.chromium.chrome.browser;
6 6
7 import android.app.Activity; 7 import android.app.Activity;
8 import android.content.Context; 8 import android.content.Context;
9 import android.graphics.Bitmap; 9 import android.graphics.Bitmap;
10 import android.graphics.Color; 10 import android.graphics.Color;
(...skipping 916 matching lines...) Expand 10 before | Expand all | Expand 10 after
927 } 927 }
928 928
929 return favicon; 929 return favicon;
930 } 930 }
931 931
932 return mFavicon; 932 return mFavicon;
933 } 933 }
934 934
935 /** 935 /**
936 * Loads the tab if it's not loaded (e.g. because it was killed in backgroun d). 936 * Loads the tab if it's not loaded (e.g. because it was killed in backgroun d).
937 * @return true iff tab load was triggered 937 * @return true iff the Tab handled the request.
938 */ 938 */
939 @CalledByNative 939 @CalledByNative
940 public boolean loadIfNeeded() { 940 public boolean loadIfNeeded() {
941 return false; 941 return false;
942 } 942 }
943 943
944 /** 944 /**
945 * @return Whether or not the tab is in the closing process. 945 * @return Whether or not the tab is in the closing process.
946 */ 946 */
947 public boolean isClosing() { 947 public boolean isClosing() {
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
1203 private native int nativeLoadUrl(long nativeTabAndroid, String url, String e xtraHeaders, 1203 private native int nativeLoadUrl(long nativeTabAndroid, String url, String e xtraHeaders,
1204 byte[] postData, int transition, String referrerUrl, int referrerPol icy, 1204 byte[] postData, int transition, String referrerUrl, int referrerPol icy,
1205 boolean isRendererInitiated); 1205 boolean isRendererInitiated);
1206 private native int nativeGetSecurityLevel(long nativeTabAndroid); 1206 private native int nativeGetSecurityLevel(long nativeTabAndroid);
1207 private native void nativeSetActiveNavigationEntryTitleForUrl(long nativeTab Android, String url, 1207 private native void nativeSetActiveNavigationEntryTitleForUrl(long nativeTab Android, String url,
1208 String title); 1208 String title);
1209 private native boolean nativePrint(long nativeTabAndroid); 1209 private native boolean nativePrint(long nativeTabAndroid);
1210 private native Bitmap nativeGetFavicon(long nativeTabAndroid); 1210 private native Bitmap nativeGetFavicon(long nativeTabAndroid);
1211 private native boolean nativeIsFaviconValid(long nativeTabAndroid); 1211 private native boolean nativeIsFaviconValid(long nativeTabAndroid);
1212 } 1212 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/android/dev_tools_manager_delegate_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698