chrome/android/java/src/org/chromium/chrome/browser/Tab.java - Issue 618513002: [DevTools] Address crash by checking if Tab loaded successfully

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 618513002: [DevTools] Address crash by checking if Tab loaded successfully (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

index 648d6446e166b08ca043ee3c15239e457b884c1a..e2eb139ef4ac760eac5468db6cb97d31931223eb 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

@@ -934,7 +934,7 @@ public class Tab implements NavigationClient {

/**

* Loads the tab if it's not loaded (e.g. because it was killed in background).

- * @return true iff tab load was triggered

+ * @return true iff the Tab handled the request.

@CalledByNative

public boolean loadIfNeeded() {

« no previous file with comments | « no previous file | chrome/browser/android/dev_tools_manager_delegate_android.cc » ('j') | no next file with comments »