Issue 618213002: Reland "Use symbols instead of hidden properties for i18n markers."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 618213002: Reland "Use symbols instead of hidden properties for i18n markers." (Closed)

Created:
6 years, 2 months ago by Yang

Modified:
6 years, 2 months ago

Reviewers:
Dmitry Lomov (no reviews)

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Reland "Use symbols instead of hidden properties for i18n markers." R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24362

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+154 lines, -162 lines)			Patch
M	include/v8.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/arm64/code-stubs-arm64.cc	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/factory.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/heap-snapshot-generator.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/heap/heap.h	View		4 chunks	+102 lines, -91 lines	0 comments	Download
M	src/heap/heap.cc	View	1	2 chunks	+5 lines, -15 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/mips64/code-stubs-mips64.cc	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/runtime/runtime.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/runtime/runtime.cc	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	src/runtime/runtime-i18n.cc	View		4 chunks	+12 lines, -11 lines	0 comments	Download
D	test/mjsunit/test-hidden-string.js	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Total messages: 4 (1 generated)

Yang

Had to revert due to compile errors on ARM/MIPS and assertion failures on snapshot=off builds. ...

6 years, 2 months ago (2014-10-01 07:46:54 UTC) #2

Yang

6 years, 2 months ago (2014-10-01 11:53:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 24362 (presubmit successful).