src/hydrogen-instructions.cc - Issue 618213002: Reland "Use symbols instead of hidden properties for i18n markers."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-instructions.cc

Issue 618213002: Reland "Use symbols instead of hidden properties for i18n markers." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: fix Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen-instructions.cc

diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc

index 9b7bfce50abc1d2dbdc2de55a173a6c8d91a9297..eb6d4f0a1d9ef755eaeb15a8196d58f30f2ddb01 100644

--- a/src/hydrogen-instructions.cc

+++ b/src/hydrogen-instructions.cc

@@ -2873,6 +2873,9 @@ bool HConstant::ImmortalImmovable() const {

object_.IsKnownGlobal(heap->name##_map()) ||

STRING_TYPE_LIST(STRING_TYPE)

#undef STRING_TYPE

+#define SYMBOL(name) object_.IsKnownGlobal(heap->name()) ||

+ PRIVATE_SYMBOL_LIST(SYMBOL)

+#undef SYMBOL

false;

}

« no previous file with comments | « src/heap/heap.cc ('k') | src/mips/code-stubs-mips.cc » ('j') | no next file with comments »