src/heap-snapshot-generator.cc - Issue 618213002: Reland "Use symbols instead of hidden properties for i18n markers."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap-snapshot-generator.cc

Issue 618213002: Reland "Use symbols instead of hidden properties for i18n markers." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: fix Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap-snapshot-generator.cc

diff --git a/src/heap-snapshot-generator.cc b/src/heap-snapshot-generator.cc

index 4a4c914e4ee0ddde726c857dd117f17dfee21505..c4f9600ba7072c62608d9cc509cce8ca9045203e 100644

--- a/src/heap-snapshot-generator.cc

+++ b/src/heap-snapshot-generator.cc

@@ -2164,6 +2164,9 @@ const char* V8HeapExplorer::GetStrongGcSubrootName(Object* object) {

#define STRING_NAME(name, str) NAME_ENTRY(name)

INTERNALIZED_STRING_LIST(STRING_NAME)

#undef STRING_NAME

+#define SYMBOL_NAME(name) NAME_ENTRY(name)

+ PRIVATE_SYMBOL_LIST(SYMBOL_NAME)

+#undef SYMBOL_NAME

#undef NAME_ENTRY

CHECK(!strong_gc_subroot_names_.is_empty());

}

« no previous file with comments | « src/factory.h ('k') | src/heap/heap.h » ('j') | no next file with comments »