Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 617953002: Strip old backend recording down to essentials (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Strip old backend recording down to essentials Feature-wise, this removes: 1) BBH support; 2) peephole optimizations; 3) record-time text op specializations; 4) the guarantee that SkPaints are flattened. This deletes the optimizations GM, which only exists to test the peepholes of the old backend. SkRecord optimizations are unit tested, and if that ever fails we can think about adding another GM like this, but they're different enough we'd want to start from scratch anyway. We need to keep the code that plays back the specialized text ops around for a while for compatibility with existing .SKPs that have those ops recorded. BUG=skia: CQ_EXTRA_TRYBOTS=tryserver.skia:Canary-Chrome-Ubuntu13.10-Ninja-x86_64-ToT-Trybot Committed: https://skia.googlesource.com/skia/+/46616af01b412ea984a516fda1ed8ec08e689f29

Patch Set 1 #

Patch Set 2 : optimizations and other cleverness in recording #

Patch Set 3 : rebase #

Patch Set 4 : revert diff #

Patch Set 5 : rebase #

Patch Set 6 : Hide flat paints. #

Patch Set 7 : NoOps #

Patch Set 8 : in recordingxfermode test, don't test old backend, and fmt #

Patch Set 9 : debug-only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -2491 lines) Patch
D gm/optimizations.cpp View 1 1 chunk +0 lines, -420 lines 0 comments Download
M gyp/core.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
M gyp/gmslides.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M gyp/tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkPicture.h View 2 2 chunks +2 lines, -19 lines 0 comments Download
M include/core/SkPictureRecorder.h View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
D src/core/SkBBoxHierarchyRecord.h View 1 chunk +0 lines, -47 lines 0 comments Download
D src/core/SkBBoxHierarchyRecord.cpp View 1 chunk +0 lines, -132 lines 0 comments Download
D src/core/SkBBoxRecord.h View 1 chunk +0 lines, -96 lines 0 comments Download
D src/core/SkBBoxRecord.cpp View 1 chunk +0 lines, -380 lines 0 comments Download
M src/core/SkPicture.cpp View 1 2 3 4 3 chunks +5 lines, -18 lines 0 comments Download
M src/core/SkPictureData.h View 2 5 chunks +0 lines, -15 lines 0 comments Download
M src/core/SkPictureData.cpp View 2 4 chunks +0 lines, -23 lines 0 comments Download
M src/core/SkPicturePlayback.h View 3 chunks +4 lines, -21 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 2 3 4 5 6 5 chunks +5 lines, -81 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 2 3 4 5 8 chunks +3 lines, -41 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 2 3 4 5 6 7 8 17 chunks +29 lines, -563 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 1 2 3 4 3 chunks +3 lines, -19 lines 0 comments Download
D src/core/SkPictureStateTree.h View 1 chunk +0 lines, -162 lines 0 comments Download
D src/core/SkPictureStateTree.cpp View 1 chunk +0 lines, -218 lines 0 comments Download
D tests/PictureStateTreeTest.cpp View 1 chunk +0 lines, -123 lines 0 comments Download
M tests/RecordingXfermodeTest.cpp View 1 2 3 4 5 6 7 7 chunks +32 lines, -97 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617953002/60001
6 years, 2 months ago (2014-09-30 18:33:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617953002/140001
6 years, 2 months ago (2014-09-30 19:47:40 UTC) #5
mtklein
No public API changes, but needs an include/ stamp.
6 years, 2 months ago (2014-09-30 19:49:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617953002/160001
6 years, 2 months ago (2014-09-30 19:55:41 UTC) #10
robertphillips
lgtm
6 years, 2 months ago (2014-09-30 20:03:28 UTC) #12
reed1
lgtm
6 years, 2 months ago (2014-09-30 20:11:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617953002/160001
6 years, 2 months ago (2014-09-30 20:12:44 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 21:47:15 UTC) #16
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as 46616af01b412ea984a516fda1ed8ec08e689f29

Powered by Google App Engine
This is Rietveld 408576698