chrome/browser/BUILD.gn - Issue 617693002: Convert components/native_app_window.gypi to a gyp to fix a cycle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/BUILD.gn

Issue 617693002: Convert components/native_app_window.gypi to a gyp to fix a cycle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix gyp, Add OWNERS, chromium_code=1 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/BUILD.gn

diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn

index 8181e41c37ef4f86bd5da4905789310b9cc538ab..a4625eb1705486d74529dd6153e30ce1268f88ea 100644

--- a/chrome/browser/BUILD.gn

+++ b/chrome/browser/BUILD.gn

@@ -76,7 +76,6 @@ static_library("browser") {

"//components/metrics:net",

"//components/metrics:profiler",

"//components/metrics/proto:proto",

- "//components/native_app_window",

"//components/navigation_metrics",

"//components/network_time",

"//components/omaha_query_params",

@@ -233,9 +232,6 @@ static_library("browser") {

#"browser_app_shim" TODO(GYP)

]

}

- if (!toolkit_views) {

- deps -= [ "//components/native_app_window" ]

- }

if (cld2_data_source == "component") {

sources += [

"component_updater/cld_component_installer.cc",

« no previous file with comments | « athena/athena.gyp ('k') | chrome/browser/ui/BUILD.gn » ('j') | chrome/chrome_browser_ui.gypi » ('J')