chrome/chrome_browser_ui.gypi - Issue 617693002: Convert components/native_app_window.gypi to a gyp to fix a cycle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 617693002: Convert components/native_app_window.gypi to a gyp to fix a cycle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix gyp, Add OWNERS, chromium_code=1 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_browser_ui.gypi

diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi

index e852dcc2cd788f92ecfbc69f86c684d2813c2885..a088352315ea79ab17dc3b5bd310692e903e2fd8 100644

--- a/chrome/chrome_browser_ui.gypi

+++ b/chrome/chrome_browser_ui.gypi

@@ -2738,6 +2738,7 @@

}],

['OS!="mac"', {

'sources': [ '<@(chrome_browser_ui_views_non_mac_sources)' ],

+ 'dependencies': [ '<(DEPTH)/components/native_app_window/native_app_window.gyp:native_app_window' ],

James Cook 2014/09/30 15:56:05 nit: This line is a little long, I might wrap it

}],

« no previous file with comments | « chrome/chrome_browser.gypi ('k') | components/BUILD.gn » ('j') | no next file with comments »