athena/athena.gyp - Issue 617693002: Convert components/native_app_window.gypi to a gyp to fix a cycle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/athena.gyp

Issue 617693002: Convert components/native_app_window.gypi to a gyp to fix a cycle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix gyp, Add OWNERS, chromium_code=1 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: athena/athena.gyp

diff --git a/athena/athena.gyp b/athena/athena.gyp

index 93c3dba90af7ec1ab91dcef1b2c39d887e071d73..cb3c25dc7d036a9af2dc9f5f1b90ac7691901f8c 100644

--- a/athena/athena.gyp

+++ b/athena/athena.gyp

@@ -128,13 +128,13 @@

'athena_lib',

'../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',

'../components/components.gyp:component_metrics_proto',

- '../components/components.gyp:native_app_window',

'../components/components.gyp:omnibox',

'../components/components.gyp:renderer_context_menu',

'../components/components.gyp:web_modal',

+ '../components/native_app_window/native_app_window.gyp:native_app_window',

+ '../content/content.gyp:content_browser',

'../extensions/extensions.gyp:extensions_browser',

'../extensions/extensions.gyp:extensions_common',

- '../content/content.gyp:content_browser',

'../ui/app_list/app_list.gyp:app_list',

'../ui/keyboard/keyboard.gyp:keyboard',

'../ui/keyboard/keyboard.gyp:keyboard_resources',

« no previous file with comments | « apps/apps.gypi ('k') | chrome/browser/BUILD.gn » ('j') | chrome/chrome_browser_ui.gypi » ('J')